Skip to content

fix(hidden-question): Adding string condition handlers for hidden question type #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ccailly wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Draft

fix(hidden-question): Adding string condition handlers for hidden question type #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/Model/QuestionType/HiddenQuestion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@
namespace GlpiPlugin\Advancedforms\Model\QuestionType;

use Glpi\Application\View\TemplateRenderer;
use Glpi\DBAL\JsonFieldInterface;
use Glpi\Form\Condition\ConditionHandler\StringConditionHandler;
use Glpi\Form\Condition\UsedAsCriteriaInterface;
use Glpi\Form\Migration\FormQuestionDataConverterInterface;
use Glpi\Form\Question;
use Glpi\Form\QuestionType\AbstractQuestionType;
Expand All @@ -46,7 +49,10 @@
* Legacy question type from the formcreator plugin
* Original source: https://github.com/pluginsGLPI/formcreator/blob/2.13.10/inc/field/hiddenfield.class.php
*/
final class HiddenQuestion extends AbstractQuestionType implements ConfigurableItemInterface, LegacyQuestionTypeInterface
final class HiddenQuestion extends AbstractQuestionType implements
ConfigurableItemInterface,
LegacyQuestionTypeInterface,
UsedAsCriteriaInterface
{
#[Override]
public function getCategory(): QuestionTypeCategoryInterface
Expand Down Expand Up @@ -150,4 +156,11 @@ public function getMapperClass(): FormQuestionDataConverterInterface
{
return new FormcreatorHiddenTypeMapper();
}

#[Override]
public function getConditionHandlers(
?JsonFieldInterface $question_config,
): array {
return array_merge(parent::getConditionHandlers($question_config), [new StringConditionHandler()]);
}
}
Loading