feat: add CP932 extensions in SJIS detection and conversion - #65
Merged
Conversation
- include the user-defined and IBM extended character areas in isSJIS - reject the undefined codes after 0xFC4B where the IBM extension ends - stop skipping leading bytes above 0x80 in isSJIS - add tests for valid and invalid SJIS byte sequences Refs #54
- add CP932 IBM extended character mappings to `convert()` - add `sjis-ext.js` for remapping SJIS codes - add `convert()` tests for IBM extended characters Refs #54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #54
Resolves #22