Repository navigation
Conversation
…2631) `local-strict-review` "Disposing of Findings" hands each `introduced` finding still open after a spent edit budget to the pull request, listed in its body. Nothing on the path to the merge carried that list, so this carries it through. - `drive-pr` "The Drive Loop" step 2 now writes each `introduced` finding still open after a spent budget into the pull request's body with its class. A later push adds its own to any list already there. - `pr-review-conduct` Merge Gate item 3 now names a body-listed finding as needing an outcome before merge, whichever head it was found on. It has no thread, so it is answered as "Answering a suppressed finding" states, citing the body's list and its length. - "Answering a suppressed finding" gains `Deferred to <issue>` and `Awaiting maintainer` verdicts, so outcomes 3 and 4 each have one. Its run-on opening sentence is split. - The generated copies are rebuilt with `build_dist.py`, and `build_dist.py --check` is clean. ## Remaining local review findings This push spent its two-round edit budget with this finding still open. The review loop gives it an outcome before merge. 1. `introduced`: `.agents/skills/pr-review-conduct/SKILL.md` "Answering a suppressed finding" allows an `Awaiting maintainer` verdict but does not say that posting it leaves the finding open. Merge Gate item 3 reads a suppressed finding as closed once "investigated and answered", so that verdict alone would satisfy item 3 while outcome 3's value call is still pending. Closes on promotion: #2613 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2632 +/- ##
=======================================
Coverage 59.34% 59.34%
=======================================
Files 16 16
Lines 8282 8282
=======================================
Hits 4915 4915
Misses 3367 3367
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved ambiguities remain around body-list formatting, finding counts, and terminal verdict handling.
1 open finding
What changed in this PR
Promotes spent-budget findings from the pull request body into Merge Gate decisions.
Changes:
- Adds body-listed finding handling to
drive-prand Merge Gate. - Adds deferred and maintainer-awaiting verdicts.
- Regenerates distributed skills and source digests.
| File | Reviewed change |
|---|---|
.github/skills/pr-review-conduct/SKILL.md |
Generated Merge Gate guidance |
.github/skills/drive-pr/SKILL.md |
Generated body-listing workflow |
.claude-plugin/fleet-skills/skills/pr-review-conduct/SKILL.md |
Generated Merge Gate guidance |
.claude-plugin/fleet-skills/skills/drive-pr/SKILL.md |
Generated body-listing workflow |
.claude-plugin/fleet-skills/.source-digests/pr-review-conduct |
Updated source digest |
.claude-plugin/fleet-skills/.source-digests/drive-pr |
Updated source digest |
.agents/skills/pr-review-conduct/SKILL.md |
Canonical Merge Gate and verdict updates |
.agents/skills/drive-pr/SKILL.md |
Canonical body-listing workflow |
🧠 Review effort: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Correction to my decline on the "Use the body list's length as the count" thread: the quoted sentence sits at lines 167-168 of |
Promotes the one change develop holds over main:
drive-prwrites a spent edit budget's remainingintroducedfindings into the pull request body,pr-review-conduct's Merge Gate gives each body-listed finding an outcome answered as a suppressed finding, and that section gainsDeferred to <issue>andAwaiting maintainerverdicts (#2631).Fixes #2613
🤖 Generated with Claude Code