Repository navigation
Conversation
#2689) ## Summary The `Lint sources job` pulled three images from Docker Hub without authenticating: editorconfig-checker, shellcheck, and shfmt. Once a runner's address used up Docker Hub's anonymous pull allowance, the step failed with `toomanyrequests` regardless of the change under test (#2682). This change pulls each image from a registry without that limit: | Was | Now | | --- | --- | | `mstruebing/editorconfig-checker:latest` | `ghcr.io/editorconfig-checker/editorconfig-checker:latest` (the project's own GHCR image) | | `koalaman/shellcheck:stable` | `mirror.gcr.io/koalaman/shellcheck:stable` | | `mvdan/shfmt:latest` | `mirror.gcr.io/mvdan/shfmt:latest` | Each new reference resolves to the same image id as the reference it replaces. `scripts/docker_lint.py`, the repo-gate `composite-actions` check (`SHELLCHECK_IMAGE`), and the two READMEs that name the images move with the workflow, so local runs keep using the same images as CI. A second commit splits a 29-word sentence on the README line this change touched. The `catalog/snippets/configs/vscode-tasks*.json` editor tasks keep the Docker Hub editorconfig-checker reference. They run locally rather than in CI, the image is identical, and changing them would give every carrying repository resync drift for no behavior change. The maintainer chose this design over authenticating to Docker Hub (a per-repository secret fleet-wide, missing on Dependabot and fork pull requests), installing the tools natively (CI tool versions drift from `docker_lint.py`), and a bounded retry (three attempts across about twenty minutes already failed on #2681). The known risk is that `mirror.gcr.io` is a pull-through cache that Google does not guarantee for these images. ## Verification - `scripts/docker_lint.py`: all 7 linters pass, pulling the new images. - `scripts/repo_gate.py`: `composite-actions`, `eol`, `eol-coverage`, and `sha-pin` all clean. `composite-actions` runs shellcheck from the new image. - `tests/test_docker_lint.py` and `tests/test_repo_gate.py`: 181 passed. - `spec/validate.py`, `ruff check`, `ruff format --check`, actionlint, and `prose_lint.py --diff` (default and `--check sentence-length`) are all clean. - Two recorded `local-strict-review` passes. The first reported only the pre-existing long sentence, which the second commit fixes, and the second reported nothing. Part of #2682. The closing reference goes on the promotion pull request. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated the container image sources used for repository validation and script checks. The checks themselves remain unchanged. * Updated setup and script documentation to reflect the revised image references. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2690 +/- ##
=======================================
Coverage 59.58% 59.58%
=======================================
Files 16 16
Lines 8316 8316
=======================================
Hits 4955 4955
Misses 3361 3361
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
0 open findings
What changed in this PR
Promotes the lint image registry migration from Docker Hub to GHCR and mirror.gcr.io, keeping tooling, CI, repository gates, and documentation aligned.
Changes:
- Moves editorconfig-checker to GHCR.
- Moves shellcheck and shfmt to
mirror.gcr.io. - Updates related lint documentation and configurations.
| File | Description |
|---|---|
scripts/README.md |
Documents the mirrored ShellCheck image. |
scripts/docker_lint.py |
Updates lint image references. |
host-setup/linux/README.md |
Updates local lint documentation. |
.github/workflows/validate-task.yml |
Uses the new CI image sources. |
.github/actions/repo-gate/repo_gate.py |
Updates the composite-action ShellCheck image. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes one change from
developtomain:mirror.gcr.io, instead of from Docker Hub. Docker Hub's unauthenticated pull limit no longer fails theLint sources job.scripts/docker_lint.py, the repo-gatecomposite-actionscheck, and two READMEs move with it.Review coverage
CodeRabbit reviewed #2689 at head
aae30bab. This promotion carries exactly that content, which anyone can re-check with two commands:git rev-parse aae30bab^{tree}andgit rev-parse a762b074^{tree}(the squash ondevelop) both print28ab155fb349021e54643ff809168b529287a074.git diff e69f3dd3 a762b074 | sha256sumandgit diff origin/main origin/develop | sha256sumprint the same hash, sincemainis at the content ofe69f3dd3.Closes #2682
🤖 Generated with Claude Code