Repository navigation
Name the Off-Grammar --branch Outcome in AUDIT.md - #2695
Conversation
The --branch paragraph described a ref that resolves and a ref that does not, but not a value off the groundTruthBranch grammar, which spec/audit.py refuses before any read with exit 2 and one stderr line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
0 open findings
What changed in this PR
Documents the invalid --branch outcome in AUDIT.md, including its grammar source and validation behavior.
Changes:
- Names
GROUND_TRUTH_BRANCH_PATTERN. - Documents rejection before reads with exit code
2.
| File | Description |
|---|---|
AUDIT.md |
Clarifies invalid --branch handling. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2695 +/- ##
==========================================
Coverage ? 59.58%
==========================================
Files ? 16
Lines ? 8317
Branches ? 0
==========================================
Hits ? 4956
Misses ? 3361
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
|
… Corrections to Main (#2740) ## Summary Promotes 20 changes from `develop` to `main`: - #2737: Flag a Lone Semicolon After an Explanatory Colon in the Prose Gate - #2734: Share pr_review.py wait's Liveness Readings and Open the Held Poll on Its Snapshot - #2732: Share One Bounded Backoff Loop Between pr_review.py wait's Two Polls - #2729: Document pr_review.py wait's Immediate 44 and check_nodes's Node Keys - #2727: Narrow pr_review.py wait's Exit 44 to Required Checks - #2722: Poll an Attested Head's Checks in pr_review.py wait - #2720: Name the Command That Enumerates Open Feature Pull Requests in backlog-burndown - #2718: Point the Skills Refresh Cadence at host-setup.md - #2716: Fall Back to os.defpath for PATH in Two Test Harnesses - #2714: State the Pip Form's Root-Config Type-Check Command in python-codestyle - #2712: State the Build Profile's CI Type Check as the Validator Runs It - #2709: Bring the Fleet-Map workflow-ci-contract Entry and G9 Gap Up to the Skill Description - #2707: Bring the Line-Endings Reference and a Test Docstring to the Corrected Wording - #2705: Drop the Stale Utilities driftNote From the Registry - #2703: Remove the Inert SC2016 Directives in configure.sh and Correct the shell-codestyle Claim - #2701: Report Whether the Fleet Skills Plugin Is Installed and Enabled in the Live Channel - #2699: Align the Audit Report Template Dimensions With AUDIT.md Section 4 - #2697: Harden the Source-Pinning Assertions in test_pr_review.py - #2695: Name the Off-Grammar --branch Outcome in AUDIT.md - #2693: Count Every Unresolved Review Thread in pr_review.py Closes #1396 Closes #2731 Closes #2723 Closes #2725 Closes #2724 Closes #2685 Closes #1308 Closes #2191 Closes #1862 Closes #2711 Closes #2025 Closes #1243 Closes #1237 Closes #1115 Closes #1156 Closes #1757 Closes #1593 Closes #1732 Closes #1509 Closes #1404 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Summary
The
--branchparagraph inAUDIT.mdnamed two outcomes of a--branchvalue: a ref that resolves, and a ref that does not resolve. It did not name the third, a value off thegroundTruthBranchgrammar, whichspec/audit.pyrefuses before any read with exit2and one stderr line. This adds one sentence naming that outcome and where the grammar lives,GROUND_TRUTH_BRANCH_PATTERNinspec/validate.py.The issue places the paragraph in section 1. It sits in section 8 ("Report"), and the edit is made where the paragraph actually is.
Verification
python3 spec/audit.py --branch 'a/../zen' ProjectTemplateprinted one stderr line and exited2, before any read.scripts/prose_lint.py --diff origin/develop,scripts/repo_gate.py --check eol,spec/validate.py, andscripts/docker_lint.py(markdownlint, cspell) all pass.local-strict-reviewpasses ran over the branch diff and are recorded. The first found the new sentence over the 25-word cap, so it is split in two. The second found nothing.Closes on promotion: #1509
🤖 Generated with Claude Code