chore: sync develop into testnet/donut (evm v0.6.3 + read-state fixes) - #368
Merged
Conversation
A nil limit makes DerivedEVMCallWithData estimate, and the estimator only sees top-level VmError — which the contract never sets, since it catches a failing callback. So it converged on gas that starved the callback it was funding.
Every other validator vote is free; read votes had validators paying per vote.
Payloads run through DerivedEVMCall, which never fires the EVM post-tx hook x/ucallback ingests from, so a read requested from a UEA was emitted and escrowed with nothing recording it.
fix(read-state): gas limits, gasless read votes, payload ingest
chore: bump evm pin to v0.6.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings develop into
testnet/donut.#367evm pin bumped to v0.6.3#366read-state fixes: explicit gas limits (N2), gaslessMsgVoteReadResult(N3), read requests from UEA payloads now ingested (N1)Donut keeps its own upgrade handlers; this only adds what develop has.