v7.15.1

[Paebbels]

Bug Fixes

• A job could download an artifact its producer never uploaded. A status check function tolerates a skipped dependency — that is what it is for — but it cannot distinguish a dependency that is unrelated from one that produces the artifact the job is about to download. Such a job started anyway and failed at the download:

  Unable to download artifact(s): Artifact not found for name: documentation-HTML
  

  Observed on GHDL's pipeline: GitHub cancelled three Windows packaging jobs, the cascade skipped the documentation job, and the publishing job ran regardless.

  Three jobs in CompletePipeline.yml now require the job producing each artifact to have succeeded:

  • PDFDocumentation requires Documentation, whose LaTeX sources it converts.
  • PublishToGitHubPages requires Documentation, PublishCoverageResults and StaticTypeCheck — the three HTML trees it assembles.
  • PublishOnPyPI requires Package, whose wheel and source distribution it uploads.

  !failure() && !cancelled() is kept alongside, so a failure anywhere in the closure still suppresses these jobs; the new terms only close the skip. None of the producers is switchable by a caller input, so this cannot disable a supported configuration.

  IntermediateCleanUp and ArtifactCleanUp are unchanged on purpose — they delete artifacts and must run whatever happened — as are TriggerTaggedRelease and ReleasePage, which download nothing.

• PrepareJob.yml and PublishReleaseNotes.yml compared a literal string. Both wrote "{FATHER_SHA}" == "" without the $, so that half of the emptiness check never fired. It was masked by the $? -ne 0 test beside it, which catches the case that actually occurs.

Changes

• The shell variable holding a merge commit's second parent is SECOND_PARENT_SHA instead of FATHER_SHA, in PrepareJob.yml (10 uses) and PublishReleaseNotes.yml (4 uses). "Second parent" is git's own term and the one the step is named after; "father" is not git terminology. GHDL's integrated copy of this logic already used that name, so the two now agree.

Documentation

• doc/Deveopment.rst, Conditional Jobs → Guidelines, states the distinction between an unrelated dependency and a producing one, with the observed failure as the worked example. The rule is not obvious from the symptom.

---

Related Issues and Pull-Requests

• Follows v7.15.0 (v7.15.0 #244).
• The same defect and the same fix in GHDL's pipeline: ghdl/ghdl#3313.

Important

r7 has to be moved to this release after merging, otherwise no consumer picks it up.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric	Results
Complexity	0
Duplication	0

View in Codacy

🟢 Coverage 100.00% diff coverage · +0.00% coverage variation

Metric	Results
Coverage variation	✅ +0.00% coverage variation
Diff coverage	✅ 100.00% diff coverage

View coverage diff in Codacy

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (958de9e)	45	41	91.11%
Head commit (3304003)	45 (+0)	41 (+0)	91.11% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#248)	1	1	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}