Skip to content

fix: use capture timestamps for alert detections - #271

Merged
fe51 merged 1 commit into
pyronear:mainfrom
Stava-Java:contrib/issue-146
Sep 9, 2026
Merged

fe51 merged 1 commit into
pyronear:mainfrom
Stava-Java:contrib/issue-146

Conversation

@Stava-Java

@Stava-Java Stava-Java commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Closes #146

Changes

Detection responses now parse recorded_at. The sequence service sorts detections by that capture timestamp. The player uses the same timestamp for slider positions, endpoint labels & the selected value label. Database created_at values no longer control playback order.

The regression test supplies two detections whose database & capture timestamps sort in opposite directions. It expects the capture-time order.

Verification

  • Vitest: 13 files, 113 tests passed
  • TypeScript project build
  • Prettier check on the 3 changed files
  • ESLint on the 3 changed files

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

@Stava-Java is attempting to deploy a commit to the Pyronear Team on Vercel.

A member of the Team first needs to authorize it.

@fe51

fe51 commented Aug 5, 2026

Copy link
Copy Markdown
Member

Hi @Stava-Java nice to meet you and thank you for opening the PR !
Thanks to it, sppoted a bug, API side, issue has been open !
pyronear/pyro-api#675

@MateoLostanlen
MateoLostanlen force-pushed the contrib/issue-146 branch 2 times, most recently from 4740779 to c085161 Compare September 3, 2026 12:29
@MateoLostanlen

MateoLostanlen commented Sep 9, 2026

Copy link
Copy Markdown
Member

On the API side, pyronear/pyro-api#687 aligns sequence started_at with the recorded_at of their first detection. This PR is complementary: the player shows capture time, the API makes it consistent with the sequence start. Both can be merged in any order.

@fe51
fe51 force-pushed the contrib/issue-146 branch from 6db845d to 59b40d0 Compare September 9, 2026 16:53
@fe51
fe51 merged commit a75e395 into pyronear:main Sep 9, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Updates detection information based on recorded_at field instead of the created_at field

4 participants