fix: use capture timestamps for alert detections - #271
Merged
Merged
Conversation
|
@Stava-Java is attempting to deploy a commit to the Pyronear Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Hi @Stava-Java nice to meet you and thank you for opening the PR ! |
MateoLostanlen
force-pushed
the
contrib/issue-146
branch
2 times, most recently
from
September 3, 2026 12:29
4740779 to
c085161
Compare
Member
|
On the API side, pyronear/pyro-api#687 aligns sequence started_at with the recorded_at of their first detection. This PR is complementary: the player shows capture time, the API makes it consistent with the sequence start. Both can be merged in any order. |
m-julio
approved these changes
Sep 9, 2026
fe51
force-pushed
the
contrib/issue-146
branch
from
September 9, 2026 16:53
6db845d to
59b40d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #146
Changes
Detection responses now parse
recorded_at. The sequence service sorts detections by that capture timestamp. The player uses the same timestamp for slider positions, endpoint labels & the selected value label. Databasecreated_atvalues no longer control playback order.The regression test supplies two detections whose database & capture timestamps sort in opposite directions. It expects the capture-time order.
Verification