Repository navigation
build(deps): patch vulnerabilities and batch Dependabot updates - #704
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #704 +/- ##
=======================================
Coverage 93.87% 93.87%
=======================================
Files 59 59
Lines 3214 3218 +4
=======================================
+ Hits 3017 3021 +4
Misses 197 197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
frgfm
force-pushed
the
fix/dependency-security-and-update-policy
branch
from
October 2, 2026 17:14
9f8a514 to
1566817
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily dependency updates were creating repeated minimum-version and observability PRs while the lockfile retained vulnerable packages. This change batches routine maintenance monthly, patches the remaining inexpensive dependency findings not covered by #695, and prevents an empty JWT signing secret from overriding the generated fallback.
Dependency fixes
Raise the PyJWT requirement to
>=2.15.0and remove the vulnerableJinja2<3.1docs constraint. Set the Sphinx minimum to the already locked 5.3.0 for compatibility with Jinja2 3.1; no other docs tooling upgrade is needed. Preserve the existing lockfile format and unrelated versions.Upstream severity does not imply every exploit is reachable here: JWT verification uses a shared secret and HS256 rather than JWKS or mixed algorithms; Jinja2 is docs-only. urllib3's response handling fixes apply to Requests-based downstream HTTP calls.
Empty JWT secret fix
Docker Compose supplies
JWT_SECRET=""when it is unset. Pydantic settings loading previously overwrote the random class default with that empty value, permitting an empty signing key with the old JWT library and causing login failures with the patched library. Generate the default per settings instance and normalize empty values after loading; preserve configured nonempty secrets exactly. Regression tests cover absent, empty, and explicit environment values.Dependabot policy
increase-if-necessaryavoids needless minimum-version raises and the wildcard group includessentry-sdk[fastapi].target-branchand the package allowlist; group security fixes across all packages separately.allow.update-types, cooldown, schedule, and version PR limits do not delay security updates or exclude required major security fixes.Existing automated PR recommendations
All four had 22 passing checks when initially inspected. #695 is now merged; this PR is rebased onto that change.
Audit scope and validation
After rebasing onto main with #695 merged, the all-groups lockfile audit reports no known vulnerabilities. This PR removes the 24 distinct advisories in AnyIO, PyJWT, urllib3, and Jinja2; #695 already removed the two SoupSieve findings.
GitHub's push summary reports 24 open alerts on the default branch (2 critical, 5 high, 16 moderate, 1 low). Its Dependabot and code-scanning alert endpoints return HTTP 403 with the available integration, so those 24 alerts cannot be reconciled individually against this audit; alert-read access is needed for that remaining review. These are dependency/advisory audit results, not a claim that the repository's private alert list is empty. Local packages and the Git-pinned camera client are excluded from package advisory matching; their registry dependencies are included. Container OS packages and source code scanning were not audited.
Pre-rebase validation:
test-backend.sh -q --maxfail=1).git diff --checkpass.GitHub CI on pre-rebase head
9f8a514: all 23 checks passed, including backend/client tests, end-to-end, Docker and client builds, CodeQL, Socket, and coverage.Rebase validation on
1566817(base710648e): lockfile and dependency synchronization checks passed, 14 configuration/security tests passed, and the all-groups dependency audit is clean. CI is rerunning for the rebased head.