Grow the sequential test set from annotator imports, append-only - #36
Merged
Merged
Conversation
The lockfile lives at data/raw/, not data/raw/fp/: the fp directory is a single DVC-tracked object whose gitignore would swallow the file and whose hash every freeze would churn. Spec updated accordingly.
- The workflow (CLAUDE.md and the planner's Next output) now refreshes test embeddings before the freeze, as the spec always required — without it a fill would select from stale embeddings. - CLAUDE.md notes that ANY ingest adding test WF sequences needs a freeze, not only annotator imports. - test_data_leakage stage depends on the ledger, registries and lockfile, so hand-edits re-trigger the consistency checks. - Same-fire chains touching planned folders in two splits now warn: that is the historical leak the guard exists for. - Drop the stale 'pre-assigned to test' comment in add_data.py.
Every command with its real output, what to check at each step, the commit checklist, and a recovery table. The README and CLAUDE.md point to it. Also corrects add_data's misleading orphan-folder warning: already-on-disk folders are skipped, not registered, so the remedy is to delete them from the pool and re-run.
Chouffe
added a commit
that referenced
this pull request
Aug 14, 2026
The frozen-lockfile test branch and the pinning simplification compose: test negatives copy the lockfile verbatim (no selection, no embeddings); train/val keep per-source pinning with the shared helpers from pyro_dataset.fp.selection. The pinning-helper tests stay in tests/test_fp_pinning.py; tests/test_build_sequential_pinning.py keeps only the frozen_test_selection coverage from main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Annotator imports can now assign sequences to all three splits (80/10/10), and
sequential_testbecomes append-only: every release's test set is a byte-identical superset of the previous one, so a model trained on an earlier dataset release stays comparable with one trained on a later release (re-evaluate the old model on the grown test set, or on the frozen old subset inside it).Design:
docs/specs/2026-08-14-annotator-test-growth-design.md(supersedes the deferred test-growth item and §4 of the 2026-08-13 import design).Why the lockfile
The built test set was never a copy of the test split — it is a KMeans selection recomputed on every build. One new WF test sequence changes
kand silently re-rolls all 151 historical negatives; test has only been stable because no dep of the stage changed. This PR replaces that accident with recorded state:data/raw/sequential_test_lock.json— ordered, append-only, git-committed list of FP folders that is the FP half ofsequential_test. Bootstrapped from the shipped test set (never recomputed), verified byte-identical through a full rebuild.scripts/freeze_test_selection.py— manual command (same state-boundary rationale asplan_annotator_import.py): pins annotator test FPs up to quota in registry order, fills remaining slots via the existing two-stage selection, never removes or reorders.build_sequential_dataset.pydoes no selection for test: it copies the lockfile verbatim and hard-errors on any mismatch (stale quota, unregistered folder, missing on disk).Also in here
assignments_from_splits/add_data.pyaccept pre-assignedtestsplits;SPLIT_TARGETSopens to 80/10/10 (greedy deficit — expect the first ~15–20 new assignments to catch up into test).(camera, azimuth)view chaining within--same-fire-window(12 h, transitive) share one split, inheriting from previously planned smoke — a fire can no longer straddle train and test.sequential_test.plan→materialise→add_data×2 →freeze_test_selection.py→dvc repro.The detector's
yolo_testdeliberately keeps its current behaviour (see Non-goals in the spec).This branch also carries the #35 recurring-object FP identity spec + plan (docs only).
Verification
uv run pytest tests/), including new suites for the lockfile, freeze command, same-fire grouping, and build errors.sequential_test/test/fp(151 folders), anddvc repro build_sequential_datasetreproduces the test split byte-for-byte (folder-list diff empty for both WF and FP).