feat: remove s3 file from annotations and use an observation array in… by Nastaliss · Pull Request #28 · pyronear/pyro-storage

Nastaliss · 2023-07-20T15:07:19Z

…stead

ghost · 2023-07-20T15:07:23Z

Nice of you to open a PR 🙏
When you're ready and want to get it reviewed, post a comment in this Pull Request with this message: /quack review

frgfm · 2023-09-16T16:40:20Z

Hey there!

Quick question: instead of an array, don't you think we should have a string (JSON dump of the dict)?

Nastaliss · 2024-01-28T19:40:05Z

Hey there!

Quick question: instead of an array, don't you think we should have a string (JSON dump of the dict)?

I have no preference, if using a jsonb is closer to what's in other tables of the db then sure :)

codecov · 2024-04-01T14:52:49Z

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.22%. Comparing base (ecafe68) to head (43e4a50).
Report is 7 commits behind head on main.

Files	Patch %	Lines
src/app/db/models.py	88.88%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   87.40%   88.22%   +0.81%     
==========================================
  Files          24       24              
  Lines         540      518      -22     
==========================================
- Hits          472      457      -15     
+ Misses         68       61       -7

Flag	Coverage Δ
unittests	`88.22% <95.00%> (+0.81%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

frgfm

The tests seem to fail with list not being hashable, would you mind checking? 🙏

Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.12.7 to 2023.7.22. - [Commits](certifi/python-certifi@2022.12.07...2023.07.22) --- updated-dependencies: - dependency-name: certifi dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.31 to 3.1.34. - [Release notes](https://github.com/gitpython-developers/GitPython/releases) - [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES) - [Commits](gitpython-developers/GitPython@3.1.31...3.1.34) --- updated-dependencies: - dependency-name: gitpython dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.34 to 3.1.35. - [Release notes](https://github.com/gitpython-developers/GitPython/releases) - [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES) - [Commits](gitpython-developers/GitPython@3.1.34...3.1.35) --- updated-dependencies: - dependency-name: gitpython dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: Adds CORS middleware * chore: Updates docker * docs: Updates README

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.15 to 1.26.17. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@1.26.15...1.26.17) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.35 to 3.1.37. - [Release notes](https://github.com/gitpython-developers/GitPython/releases) - [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES) - [Commits](gitpython-developers/GitPython@3.1.35...3.1.37) --- updated-dependencies: - dependency-name: gitpython dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.17 to 1.26.18. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@1.26.17...1.26.18) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

feat: remove s3 file from annotations and use an observation array in…

bc98566

…stead

github-actions Bot added route: annotations module: database labels Jul 20, 2023

GHCamille mentioned this pull request Sep 22, 2023

Connexion to back 🔗 Nastaliss/pyro-crowd#11

Open

Nastaliss added 2 commits April 1, 2024 15:24

fix: image path

ae0ed9b

feat: add correct tests for annotations and observations

ceec8b5

github-actions Bot added the ext: tests label Apr 1, 2024

feat: sort types

3acab3b

feat: update only observations

c1d8d3c

github-actions Bot added ext: client ext: client/tests labels Apr 1, 2024

Nastaliss added 2 commits April 1, 2024 17:40

test: build docker wait for probing doc

a7496a3

feat: add health-check

d26245c

github-actions Bot added the topic: docker label Apr 1, 2024

Nastaliss added 5 commits April 1, 2024 17:48

feat: remove hc on backend;

20f218e

feat: hard-code env vars for db

620934b

feat: wait for condition healthy

6b27953

feat: add health-checks in dev

5d89bf5

feat: lint

5267883

frgfm reviewed May 24, 2024

View reviewed changes

Nastaliss and others added 6 commits July 1, 2024 14:17

chore: retrigger ci

62c4f9f

feat: Enables CORS using FastAPI middleware (#26)

64941bd

* feat: Adds CORS middleware * chore: Updates docker * docs: Updates README

dependabot Bot added 2 commits July 1, 2024 23:45

github-actions Bot added the topic: documentation Improvements or additions to documentation label Jul 1, 2024

Nastaliss added 4 commits July 1, 2024 23:50

fix: use string as json key

0acfed9

fix: no explicit none

43e4a50

Merge branch 'main' into simplify-annotations

0c1f2f2

Merge remote-tracking branch 'origin/main' into simplify-annotations

793a7bb

github-actions Bot removed the topic: documentation Improvements or additions to documentation label Jul 6, 2024

Navigation Menu

Uh oh!

feat: remove s3 file from annotations and use an observation array in… - #28

feat: remove s3 file from annotations and use an observation array in…#28
Nastaliss wants to merge 24 commits into
mainfrom
simplify-annotations

Nastaliss commented Jul 20, 2023

Uh oh!

ghost commented Jul 20, 2023

Uh oh!

frgfm commented Sep 16, 2023

Uh oh!

Nastaliss commented Jan 28, 2024

Uh oh!

codecov Bot commented Apr 1, 2024 •

edited

Loading

Uh oh!

frgfm left a comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Nastaliss commented Jul 20, 2023

Uh oh!

ghost commented Jul 20, 2023

Uh oh!

frgfm commented Sep 16, 2023

Uh oh!

Nastaliss commented Jan 28, 2024

Uh oh!

codecov Bot commented Apr 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

frgfm left a comment

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Apr 1, 2024 •

edited

Loading