Repository navigation
fix: preserve fixed metadata state when set_program fails - #154
Open
pro-utkarshM wants to merge 1 commit into
Open
pro-utkarshM wants to merge 1 commit into
pro-utkarshM wants to merge 1 commit into
Conversation
Validate the replacement program before installing its metadata buffer and pointer offsets. Otherwise a verifier error leaves the old bytecode loaded with the replacement's metadata layout. Cover default and custom verifier rejection with a regression test that checks the original program still reads the correct packet length. Signed-off-by: Utkarsh Maurya <projects.utkarshMaurya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rejected replacement program currently leaves
EbpfVmFixedMbuffrunning its old bytecode with the replacement's metadata buffer and offsets. For example, a program reading pointers at offsets 8 and 16 returns 0 instead of the packet length afterset_program(&[], 0, 24)fails.Validate the replacement through the parent VM before committing the new metadata state. Add a regression test covering rejection by both the default verifier and a custom verifier.
Fixes #153.
Validation:
0instead of3) and passes afterward.cargo test --all-featurescargo test --no-default-features -j 2cargo clippy --all-features --all-targets -j 2(existing style warnings)git diff --check