Repository navigation
Fix timeout worker output filtering and failing p-code tests - #307
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two failing Linux CI tests exercise
pdgj/pdgxwithr2ghidra.timeout. The child flushes directly to stdout, bypassing the parent console where JSON selectors, grep counts and redirections are applied. The tests also set the plugin option with-ebefore plugin initialization, producing an unknown-variable error on radare2 6.2.4.Send the child's raw console buffer through the pipe and append it to the parent console after successful completion. Drain the pipe while enforcing a monotonic deadline so output larger than the pipe capacity cannot deadlock. Reset the inherited child buffer, handle interrupted/partial I/O, close descriptors on fork failure, and use
_exitto avoid flushing inherited stdio. Set the timeout inside the existing test command sequences after plugin initialization.Validation against the same radare2 6.2.4 release used by CI:
make -C test: 189 passed, 0 failed.The macOS ARM failure in the master run was a transient
Could not resolve host: github.comwhile cloning ghidra-native. That job has been retried; no platform build workaround is included.