Remove submodule-era residue from REUSE.toml and .soldeerignore - #19
Conversation
Seven dangling entries for paths that do not exist on main (.gitmodules, foundry.lock, audit/, meta/). Config-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 27 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
audit/ and /meta are forward-looking guards for directories that may be added, like /out and /cache; removing them would publish those files and risk reuse lint. Only .gitmodules and foundry.lock are structurally dead (no-submodules gate). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Removes the dangling
.gitmodulesandfoundry.lockentries fromREUSE.tomland.soldeerignore— submodule-era residue that survived silently becausereuse linttolerates missing annotation paths and a.soldeerignoreline for a nonexistent path is a no-op.Removed (structurally dead)
REUSE.toml:".gitmodules","foundry.lock".soldeerignore:.gitmodules,/foundry.lockThis repo vendors deps via soldeer (
libs = ["dependencies"],soldeer.lock, nolib/), so a Foundry submodule lockfile and.gitmodulescannot come back — rainix'sno-submodulesgate fails on either. Neither path exists onmain.Kept — forward-looking guards, not residue
audit/(REUSE.toml audit/**/,.soldeerignore /audit) and/metaare ignores/annotations for directories that may legitimately be added later — the same category as/out,/cache,/dependencies, which are also absent at rest and kept by design./auditkeeps future audit reports out of the published soldeer package andaudit/**/keeps them from failingreuse lint; removing them would silently publish those files and/or break thelegaljob. Also kept:/script,/test,/remappings.txt,.DS_Store,.pre-commit-config.yaml,.vscode,CLAUDE.md.Config-only: no Solidity source, no deployed bytecode, no audited artifact changes.
Closes #12
QA
.gitmodulesandfoundry.lockare absent onmainand cannot return (rainixno-submodulesgate);reuse lint(thelegaljob) stays green andforge buildis unaffected - verified locally (reuse lintcompliant 33/33, build clean)..gitmodules,foundry.lock); deliberately keptaudit/and/meta(forward-looking guards for directories that may be added, like/outand/cache), which the issue mis-classified as residue.