Skip to content

Remove submodule-era residue from REUSE.toml and .soldeerignore - #19

Merged
thedavidmeister merged 2 commits into
mainfrom
2026-08-20-issue-12-submodule-residue
Aug 20, 2026
Merged

Remove submodule-era residue from REUSE.toml and .soldeerignore#19
thedavidmeister merged 2 commits into
mainfrom
2026-08-20-issue-12-submodule-residue

Conversation

@thedavidmeister

@thedavidmeister thedavidmeister commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Removes the dangling .gitmodules and foundry.lock entries from REUSE.toml and .soldeerignore — submodule-era residue that survived silently because reuse lint tolerates missing annotation paths and a .soldeerignore line for a nonexistent path is a no-op.

Removed (structurally dead)

  • REUSE.toml: ".gitmodules", "foundry.lock"
  • .soldeerignore: .gitmodules, /foundry.lock

This repo vendors deps via soldeer (libs = ["dependencies"], soldeer.lock, no lib/), so a Foundry submodule lockfile and .gitmodules cannot come back — rainix's no-submodules gate fails on either. Neither path exists on main.

Kept — forward-looking guards, not residue
audit/ (REUSE.toml audit/**/, .soldeerignore /audit) and /meta are ignores/annotations for directories that may legitimately be added later — the same category as /out, /cache, /dependencies, which are also absent at rest and kept by design. /audit keeps future audit reports out of the published soldeer package and audit/**/ keeps them from failing reuse lint; removing them would silently publish those files and/or break the legal job. Also kept: /script, /test, /remappings.txt, .DS_Store, .pre-commit-config.yaml, .vscode, CLAUDE.md.

Config-only: no Solidity source, no deployed bytecode, no audited artifact changes.

Closes #12

QA

  • Discriminating tests: n/a - config-only diff, no behavior to test; the oracle is structural (below).
  • Mutations applied: n/a - no code paths to mutate.
  • Oracle: .gitmodules and foundry.lock are absent on main and cannot return (rainix no-submodules gate); reuse lint (the legal job) stays green and forge build is unaffected - verified locally (reuse lint compliant 33/33, build clean).
  • Category check: issue asks to remove REUSE.toml lines 10/11/19 and .soldeerignore lines 7/12/17/19 - removed only the four structurally-dead submodule lines (.gitmodules, foundry.lock); deliberately kept audit/ and /meta (forward-looking guards for directories that may be added, like /out and /cache), which the issue mis-classified as residue.

Seven dangling entries for paths that do not exist on main (.gitmodules, foundry.lock, audit/, meta/). Config-only.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this Aug 20, 2026
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@thedavidmeister, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c3e8ef64-4218-4938-bfe6-1e107e8e53a0

📥 Commits

Reviewing files that changed from the base of the PR and between 4292435 and 62be4eb.

📒 Files selected for processing (2)
  • .soldeerignore
  • REUSE.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

audit/ and /meta are forward-looking guards for directories that may be added, like /out and /cache; removing them would publish those files and risk reuse lint. Only .gitmodules and foundry.lock are structurally dead (no-submodules gate).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@thedavidmeister
thedavidmeister merged commit 6deef89 into main Aug 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the submodule-era residue — dangling REUSE.toml/.soldeerignore entries for foundry.lock, .gitmodules and audit/

1 participant