Skip to content

Drop foundry.toml release metadata: version intent lives in next-v tags (rainix#335) - #39

Open
thedavidmeister wants to merge 1 commit into
mainfrom
2026-08-19-drop-release-metadata
Open

Drop foundry.toml release metadata: version intent lives in next-v tags (rainix#335)#39
thedavidmeister wants to merge 1 commit into
mainfrom
2026-08-19-drop-release-metadata

Conversation

@thedavidmeister

@thedavidmeister thedavidmeister commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Drops the [external.package] release-metadata section (and its attached comment block) from foundry.toml, per the ruling on rainlanguage/rainix#335. Since rainlanguage/rainix#336 merged, rainix-autopublish derives the publish version from the Soldeer registry + next-v* git tags and never reads this section, and the publish gate excludes the section (including its attached comment block) from the content hash — so this deletion is content-neutral: it cannot mint a spurious release and changes no behavior. Verified locally: nix develop -c reuse lint (compliant), forge soldeer install and forge test (8 passed, 0 failed).

QA

  • Discriminating tests: n/a - config-metadata deletion; nothing reads the section since rainix#336 (local nix develop -c forge test: 8 passed, 0 failed; reuse lint compliant)
  • Mutations applied: n/a - no code changed
  • Oracle: rainix#336 gate semantics (section excluded from content hash; version from registry + next-v tags)
  • Category check: issue asks removal of release metadata from consumers; covered exactly for this repo

Summary by CodeRabbit

  • Chores
    • Removed obsolete release metadata from the project configuration.
    • No changes to application functionality or dependency settings.

…gs (rainix#335)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this Aug 19, 2026
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 035a5755-4245-4856-940a-07b2c055592d

📥 Commits

Reviewing files that changed from the base of the PR and between c85efb0 and b77b770.

📒 Files selected for processing (1)
  • foundry.toml
💤 Files with no reviewable changes (1)
  • foundry.toml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The change removes the [external.package] release metadata from foundry.toml. Other Foundry, fuzz, dependency, and Soldeer settings remain unchanged.

Changes

Release metadata

Layer / File(s) Summary
Remove external package metadata
foundry.toml
Removes the rain-math-binary package name and 0.1.5 version used by rainix-autopublish.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to b77b7

This is a localized removal of obsolete release metadata with no actionable merge-blocking risk remaining after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of release metadata from foundry.toml and the new version source.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-08-19-drop-release-metadata

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant