Skip to content

Drop the "cut no release yet" comment on the chain test - #16

Open
thedavidmeister wants to merge 1 commit into
mainfrom
2026-08-27-drop-stale-no-release-comment
Open

Drop the "cut no release yet" comment on the chain test#16
thedavidmeister wants to merge 1 commit into
mainfrom
2026-08-27-drop-stale-no-release-comment

Conversation

@thedavidmeister

@thedavidmeister thedavidmeister commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

DecimalFloatDeployChainTest's comment said this repo has cut no release under
the frozen-record model, so releasedSuites() is empty and the inherited test
has no subject and forks nothing.

It has a subject. src/generated/0_1_1/DecimalFloat.sol and
src/generated/0_1_1/LogTables.sol are frozen on main,
LibDecimalFloatReleased declares decimal-float@0_1_1 and
LibLogTablesReleased declares log-tables@0_1_1, so releasedSuites()
returns those and the chain group forks every supported network against them.
A reader is told the test is inert when it is the opposite.

Deleted rather than corrected, per the ruling on rainlanguage/rain.deploy#153:
naming 0_1_1 re-arms the same trap, because the next release falsifies it again
and nothing expires a comment.

Only the transient half goes — that this repo has released nothing, that
releasedSuites() is therefore empty, and that it gains a subject when the
first src/generated/<tag>/ lands. The sibling sentence is durable and stays
verbatim: LibDecimalFloatDeployProdTest checks the live CURRENT pins, which is
a different claim, because the candidate is what the NEXT release will be and a
released suite is a deployment that already happened. Nothing in the file shows
that, and no release can falsify it. The remaining lines are a rewrap of words
already there; no replacement prose was added.

QA

  • Discriminating tests: n/a - the diff deletes doc comment text only, no behaviour to discriminate. Verified by git diff: every changed line is a /// line above the contract, and the two lines that appear as additions are the surviving sentence rewrapped after the words in front of it were cut.
  • Mutations applied: n/a - comment-only diff, there is no executable line in it to mutate.
  • Oracle: the tree, not the comment. src/generated/0_1_1/DecimalFloat.sol and src/generated/0_1_1/LogTables.sol exist on main, and src/lib/LibDecimalFloatReleased.sol / src/lib/LibLogTablesReleased.sol emit suite: "decimal-float@0_1_1" and suite: "log-tables@0_1_1" into releasedSuites() via LibReleasedSuites. That is what makes the deleted sentences false, read from the frozen record and the generated libs rather than from any prose. The retained sentence was checked too: LibDecimalFloatDeployProdTest exists, at test/src/lib/deploy/LibDecimalFloatDeployProd.t.sol.
  • Category check: DecimalFloatDeployChainTest's comment claims this repo has cut no release, but 0_1_1 is frozen #14 asks for one comment in one file; covered test/src/abstract/DecimalFloatDeployChain.t.sol. Also grepped this repo for the same class of claim ("cut no release", "released none", "has released", "no subject") and this file held the only occurrence.

Closes #14

Summary by CodeRabbit

  • Documentation
    • Updated contract-level test documentation by removing outdated release-model and test-status details.
    • Retained the description of the live current-pins validation.

`src/generated/0_1_1/{DecimalFloat,LogTables}.sol` are frozen and the
released libs declare `decimal-float@0_1_1` and `log-tables@0_1_1`, so
`releasedSuites()` is not empty and the inherited test has a subject and
forks every supported network. The comment said the opposite.

Deleted rather than corrected: naming 0_1_1 re-arms the same trap at the
next release, and nothing expires a comment. The sibling sentence stays
because it is durable — `LibDecimalFloatDeployProdTest` checks the live
CURRENT pins, which is a different claim from a release that already
happened.

Closes #14

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9ba5c76f-adfa-4971-a3fd-75ebcebe6957

📥 Commits

Reviewing files that changed from the base of the PR and between 27960f0 and c58255f.

📒 Files selected for processing (1)
  • test/src/abstract/DecimalFloatDeployChain.t.sol

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The contract-level documentation comment no longer states that no frozen release exists or that the inherited test is inactive. It retains the explanation of the live CURRENT pins check.

Changes

Deployment test documentation

Layer / File(s) Summary
Remove stale release-status comment
test/src/abstract/DecimalFloatDeployChain.t.sol
Removes outdated statements about empty released suites and inactive inherited tests. Retains the CURRENT pins check description.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to c5825

This change only removes stale explanatory text from a test file and does not alter test behavior or production code. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the outdated no-release comment from the chain test.
Linked Issues check ✅ Passed The change satisfies issue #14 by deleting the inaccurate no-release comment in DecimalFloatDeployChain.t.sol and retaining the durable CURRENT-pins explanation.
Out of Scope Changes check ✅ Passed The pull request changes only the targeted documentation comment. No unrelated code or scope expansion is present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-08-27-drop-stale-no-release-comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DecimalFloatDeployChainTest's comment claims this repo has cut no release, but 0_1_1 is frozen

1 participant