[5.x] - Fix product structured data on PDP - #1302
Open
JimmyHoenderdaal wants to merge 5 commits into
Open
Conversation
Jade-GG
requested changes
Jun 2, 2026
Jade-GG
previously approved these changes
Jun 10, 2026
royduin
reviewed
Jun 30, 2026
royduin
reviewed
Jun 30, 2026
royduin
reviewed
Jun 30, 2026
Roene-JustBetter
changed the title
royduin
reviewed
Jul 22, 2026
| <meta itemprop="url" content="{{ url($product->url) }}" /> | ||
| @if ($product->special_to_date && $product->special_to_date > now()->toDateTimeString()) | ||
| <meta itemprop="priceValidUntil" content="{{ $product->special_to_date }}" /> | ||
| @php $specialToDate = $product->raw('special_to_date'); @endphp |
Member
There was a problem hiding this comment.
Normal $product->special_to_date access runs the value through HTML-escaping meant for display text, which turns the underlying Carbon date into a plain string. raw() skips that and returns the attribute's cast value directly — a real Carbon instance, since AttributeDatetime casts it to 'datetime'. The template needs that Carbon object to call ->isFuture() and ->format('Y-m-d').
RAP-2010 created to remove html escaping from EAV dates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some extra microdata inside the schema Offer:
<meta itemprop="itemCondition" content="https://schema.org/NewCondition" />priceValidUntilBoth are recommended to add inside the schema.
Internal ref: RAP-1899