RDBC-1099 Sync 7.2.3 -> 7.2.6 - #309
Open
poissoncorp wants to merge 30 commits into
Open
Conversation
from_json required an AutoIndexes key and a LockMode, so any payload without them raised. Both C# fields have no initializer: a missing AutoIndexes leaves null, and a missing LockMode lands on Unlock. to_json also iterated the auto-index dict without .items(), so it never serialized one.
Ports RemoteAttachmentExtensions. Backup S3Settings gains the StorageClass it was missing, and the S3 and Azure from_json / to_json paths stop requiring keys that C# treats as optional, since a converted instance carries no backup script.
Operation.wait_for_completion now hands back the result the server carried instead of dropping it, and the smuggler narrows that to a SmugglerResult with per-item-type counts. No existing caller used the return value.
This test pinned wait_for_completion returning None, which is the behaviour the previous commit deliberately changed. It now checks the result the server sent.
AiOutputOptions carries a sample object, an explicit JSON schema, or no schema at all, and run_with_schema / stream_with_schema apply it to a single turn. Nothing is sent when no options are given, so the agent's own schema stays in charge.
VectorSearchToken inherited the base add_alias, which builds a plain WhereToken and so dropped the similarity threshold, candidate count and exactness. It now rebuilds itself with the field qualified. The caller also discarded what add_alias returned, so no alias was ever applied. C# assigns the new token back into the list; this does the same.
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDBC-1112 Sync Python SDK 7.2.5 -> 7.2.6
RDBC-1099 Sync Python SDK 7.2.3 -> 7.2.5