chore: add TestNet block activation for v1.4.1 hardforks - #190
bdimitrov-netzine wants to merge 1 commit into
Conversation
|
Claude finished @bdimitrov-netzine's task in 1m 13s —— View job Code Review
SummaryStraightforward configuration change activating two v1.4.1 hardforks on testnet by promoting them from ObservationsSame block for both forks (17_300_000) Both No tests for the new testnet activation blocks The existing test suite has activation tests for earlier hardforks following this pattern: #[test]
fn admin_transfer_active_after_testnet_activation_block() {
let hardforks = RaylsChainHardforks::for_network(RaylsNetwork::Testnet);
assert!(!hardforks.is_rayls_fork_active_at_block(...BLOCK - 1));
assert!( hardforks.is_rayls_fork_active_at_block(...BLOCK + 1));
}
#[test]
fn admin_transfer_never_activates_on_devnet() { ... }The new constants ( Comment update is accurate The doc comment for No devnet constants defined Prior hardforks (e.g., VerdictNo correctness issues. The change is safe to merge as-is. The main suggestion is adding boundary tests to match the existing test coverage pattern. |
The problem
Summary
Closes #
Surface areas touched
eth_*,rayls_*, faucet)rayls-contracts/)etc/, scripts, Docker, compose).github/workflows/,Makefile)doc/, in-crate READMEs, root docs)Breaking / compatibility
None.
Test plan