Skip to content

Fix implicitly marking parameter in JWTCreationException - #38

Closed
gomzyakov wants to merge 1 commit into
readdle:mainfrom
gomzyakov:fix-implicitly-marking-parameter
Closed

Fix implicitly marking parameter in JWTCreationException#38
gomzyakov wants to merge 1 commit into
readdle:mainfrom
gomzyakov:fix-implicitly-marking-parameter

Conversation

@gomzyakov

Copy link
Copy Markdown

This PR fixed "implicitly marking parameter" warning when app using PHP 8.4:

PHP Deprecated: Readdle\AppStoreServerAPI\Exception\JWTCreationException::__construct(): 
Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/readdle/app-store-server-api/src/Exception/JWTCreationException.php on line 10

@gomzyakov

Copy link
Copy Markdown
Author

@rkovsher @pkotets

Hello! Can you review & approve this PR?

@pkotets

pkotets commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Thanks!
However, this PR became irrelevant since a bunch of changes in v3.18.0 includes this fix as well.

@pkotets pkotets closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants