COR-186 - Ensure checking SSL Certificate in IMAP StartTLS. - #106
Merged
dbezverkhnii merged 1 commit intoSep 4, 2026
Merged
Conversation
(cherry picked from commit fad23d7)
dbezverkhnii
deleted the
feature/COR-186-cherry-pick-imap-starttls-certificate-check
branch
September 4, 2026 04:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit fad23d7)
Note
High Risk
Changes TLS trust behavior on the IMAP StartTLS connect path; invalid or mismatched certificates will now fail login instead of being accepted.
Overview
StartTLS IMAP connects now run the same certificate check as direct TLS, closing a gap where a successful
STARTTLSupgrade could continue without validating the server cert.After
mailimap_socket_starttlssucceeds,connectcallscheckCertificate()(honoringisCheckCertificateEnabled()). Failure setsErrorCertificateand tears down the session, matching the existingConnectionTypeTLSbranch. Log lines for the TLS connect path are prefixed with"TLS"for easier distinction from StartTLS cert errors.Reviewed by Cursor Bugbot for commit 271b9c1. Bugbot is set up for automated code reviews on this repo. Configure here.