Temp/reserve imap connecteon for operation - #99
Closed
dbezverkhnii wants to merge 9 commits into
Closed
Conversation
Idle timer stands down while a connection is reserved and is re-armed by releaseConnection; releaseConnection is idempotent and owner-checked; selection no longer stamps the affinity hint on reserved connections; threading contract documented; test endpoint descriptor lifecycle fixed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Bridges the existing IMAPAsyncConnection::disconnectOperation() to C and Swift so a lease holder can tear its socket down before commands whose freshness matters: the next command logs in from scratch and sees the server's current mailbox view. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The installed header set was self-inconsistent: CIMAPAsyncSession.h, CIMAPBaseOperation.h and CCore.h include CIMAPAsyncConnection.h, but the CMake install list did not carry it. Also rights the leaked-lease wording in the Swift docs: the pool degrades to sharing, it does not shrink. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Swift-only: exposes the underlying pool connection's pointer as an opaque identity, unique and constant for the owning session's lifetime, so the client can key per-connection bookkeeping (view-freshness generations) across separate acquisitions of the same connection. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The mailcore2-all-<N>.zip archives for the Windows build are stored as release assets of this repository instead of the S3 bucket; upload and verification instructions now go through gh release. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Build-Helpers.ps1 provides minimal stand-ins for RDBuildCMake/RDBuildMSVC/ RDDependency and is dot-sourced only when those modules are absent, so a plain clone of the public repository builds with just the Swift toolchain and VS Build Tools. Dependencies are cloned over https instead of ssh, and one optional -PrebuiltDependenciesArchive supplies ICU, libxml2, openssl, sasl and zlib, replacing the S3 downloads and the manual C:\Library layout. Also installs the ICU and Swift runtime DLLs the artifact needs, fixes the tidy include/lib paths, and adds MCIMAPAsyncConnection.h to the C++ public headers - the C++ half of the header-install fix in 00e17d8. Authored on Windows by the build agent; carried over verbatim except for comments and the header-list fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…n COR-180 The archive is now named after the C/C++ sources it was built from (mailcore2-all-<digest>.zip), so there is no version to bump and no way to silently consume a stale binary: sources that were never built have no archive, and the spark-core build stops with a message naming the missing one. Since there is no Windows CI, that build is where the omission surfaces. The digest covers src minus src/swift, CMakeLists.txt and the new windows-build-pins.json (exact dependency revisions and toolchain versions), and is computed from git's tree entries, which makes it identical across platforms regardless of core.autocrlf. Build scripts are deliberately outside it: editing them must not invalidate good binaries. Publish-Mailcore2Prebuilt.ps1 does the whole job in one call - digest, skip if already published, toolchain check, build, stamp, package, verify, upload - and nothing needs to be committed afterwards. Downloads need no credentials now that the repository is public; the S3 path survives behind -LegacyS3Version for tags published before this change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3ded97b. Configure here.
| New-Item -ItemType Directory -Path $Path -Force | Out-Null | ||
| foreach ($dependency in $Dependencies) { | ||
| $destination = Join-Path $Path $dependency.Directory | ||
| if (Test-Path -LiteralPath (Join-Path $destination ".git")) { continue } |
There was a problem hiding this comment.
Stale deps ignore pin updates
High Severity
Initialize-Dependencies treats any existing .git directory as ready and never re-checks HEAD against the pinned GitRevision. Publish-Mailcore2Prebuilt.ps1 reuses .build\prebuilt\build-dependencies across runs, so a later publish after a pin change still builds ctemplate, libetpan, and tidy from the old checkout while naming the archive after the new digest.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 3ded97b. Configure here.
| $swiftRoot = Join-Path $env:LOCALAPPDATA "Programs\Swift" | ||
| $swiftBin = Get-ChildItem -LiteralPath (Join-Path $swiftRoot "Toolchains") -Filter clang-cl.exe -Recurse -File | | ||
| Select-Object -First 1 -ExpandProperty DirectoryName | ||
| if (-not $swiftBin) { throw "Swift clang-cl.exe not found under $swiftRoot" } |
There was a problem hiding this comment.
Wrong Swift compiler can be used
Medium Severity
Initialize-Toolchain puts the first clang-cl.exe it finds under the Swift toolchains directory on PATH, and does not select the version from windows-build-pins.json. Publish-Mailcore2Prebuilt.ps1 only checks that the pinned Swift platform folder exists, so a machine with multiple Swift installs can compile the prebuilt with a different clang than the digest claims.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 3ded97b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
High Risk
Changes core IMAP connection pooling, reservation, and stream cancellation semantics used by Spark; Windows consumers need a new prebuilt for any C/C++ digest change or builds fail at download time.
Overview
Adds exclusive IMAP connection leases so callers can reserve a pool connection, pin operations to it (
setConnection/setSession), and return it with optional disconnect. Reserved connections are skipped by normal session selection; idle auto-disconnect is configurable (automaticDisconnectDelay) and paused while leased.interruptCurrentCommand()aborts the currently running operation’s blocked IMAP read viaOperationQueue::interruptRunningOperationandmailstream_cancel, with matching C/Swift APIs (MCOIMAPAsyncConnection,acquireConnection/releaseConnection). Darwin unit tests cover leasing, pinning, exhaustion, and interrupt behavior.Separately, Windows MailCore prebuilts move from numbered S3 zips to
mailcore2-all-<digest>.zipon GitHub releases (windows-prebuilt), where the digest hashes committed C/C++ inputs pluswindows-build-pins.json.Publish-Mailcore2Prebuilt.ps1builds, verifies, and uploads;Get-Mailcore2.ps1downloads publicly and validates the stamped digest (-LegacyS3Versionkeeps the old path).Build-Helpers.ps1and a bundled dependency archive reduce reliance on internal RD modules, AWS keys, and fixedC:\Librarypaths. Docs (README,AGENTS.md) describe the new publish flow.Reviewed by Cursor Bugbot for commit 3ded97b. Bugbot is set up for automated code reviews on this repo. Configure here.