[Php74] Fix isset guard never converting on IfToNullCoalescingAssignRector - #8389
Merged
TomasVotruba merged 1 commit intoAug 28, 2026
Conversation
Soean
marked this pull request as ready for review
August 27, 2026 12:35
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-nullable property skip from #8387 reads the type off the fetch node returned by
matchNullGuardedExpr(). For the! isset($prop)form that node sits insideIsset_, where PHPStan has already narrowednullout of the type.TypeCombinator::containsNull()is therefore alwaysfalse,isNonNullableProperty()always returnstrue, and the skip fires for every property underisset, nullable or not.Before (same nullable property, three guard forms)
Only the
issetform is affected, so it was silently disabled for properties, including the case the rule advertises in itsCodeSample.Fix
Resolve the declared type through
ReflectionResolver::resolvePropertyReflectionFromPropertyFetch()instead ofnodeTypeResolver->getType()on the fetch node.getReadableType()stays phpdoc-aware like the previous call, but carries no scope narrowing.After
skip_typed_non_nullable_property.php.inckeeps skipping, so the boundary #8387 intended is unchanged, the two fixtures now pin it from both sides.