Skip to content

ci: remove the deployment cleanup job - #6563

Merged
pawelangelow merged 1 commit into
mainfrom
ric/ci-remove-deployment-cleanup
Nov 10, 2026
Merged

pawelangelow merged 1 commit into
mainfrom
ric/ci-remove-deployment-cleanup

Conversation

@pawelangelow

@pawelangelow pawelangelow commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

What

Removes the Clean deployments job and its reusable workflow (clean-deployments.yml) from the manual build, enterprise manual build and tests workflows.

The job deleted old deployment records in one burst of API calls. GitHub's secondary rate limit rejects that, so the job failed and marked every run red, even when all builds passed. The gh-pages step also targeted an environment that doesn't exist (the environment is github-pages).

What are deployment records?

Just history. Whenever a job runs against an environment (production, staging, ...), GitHub logs "commit X ran in production at time T". Nothing in this repo reads or reuses these records, and GitHub doesn't remove old ones on its own.

Environments, their secrets, variables and approval gates are untouched. Only the history cleanup goes away, so the Deployments list will keep growing (about 9 new production records a day).

Testing

  • All three edited workflows parse as valid YAML.
  • No references to clean-deployments remain, and no needs: points at the removed job.
  • The required-checks-passed job never listed the cleanup, so merge gating is unchanged.
  • This PR's Tests run passes end to end.
  • The manual build workflows only run on demand, so after merge, run one manual build and confirm it ends green.

Note

Low Risk
CI-only change removing a failing maintenance job; no application code, secrets, or merge requirements affected.

Overview
Removes the Clean deployments reusable workflow and every workflow job that invoked it from manual build, enterprise manual build, and tests.

Those jobs bulk-deleted GitHub deployment history for staging, production, and related environments. They were failing (rate limits and a wrong gh-pages environment name) and could turn otherwise green runs red, without affecting actual deploy targets—only historical deployment records. Artifact cleanup and merge gating (required-checks-passed) are unchanged; deployment history will simply accumulate going forward.

Reviewed by Cursor Bugbot for commit 9aa5cda. Bugbot is set up for automated code reviews on this repo. Configure here.

The job deleted old deployment records in one burst of API calls, which
GitHub's secondary rate limit rejects, so runs ended red. Nothing reads
the records, and the gh-pages step targeted a nonexistent environment.
@pawelangelow
pawelangelow temporarily deployed to production October 31, 2026 12:11 — with GitHub Actions Inactive
@pawelangelow
pawelangelow temporarily deployed to production October 31, 2026 12:11 — with GitHub Actions Inactive
@pawelangelow
pawelangelow temporarily deployed to production October 31, 2026 12:11 — with GitHub Actions Inactive
@pawelangelow
pawelangelow temporarily deployed to production October 31, 2026 12:11 — with GitHub Actions Inactive
@pawelangelow
pawelangelow temporarily deployed to production October 31, 2026 12:11 — with GitHub Actions Inactive
@pawelangelow
pawelangelow temporarily deployed to production October 31, 2026 12:11 — with GitHub Actions Inactive
@pawelangelow
pawelangelow temporarily deployed to production October 31, 2026 12:11 — with GitHub Actions Inactive
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage - Backend unit tests

St.❔
Category Percentage Covered / Total
🟢 Statements 93.29% 16884/18099
🟡 Branches 75.68% 5429/7174
🟢 Functions 87.75% 2592/2954
🟢 Lines 93.15% 16146/17334

Test suite run success

3924 tests passing in 331 suites.

Report generated by 🧪jest coverage report action from 9aa5cda

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage - Integration Tests

Status Category Percentage Covered / Total
🟡 Statements 79.61% 18586/23344
🟡 Branches 62.11% 8701/14009
🟡 Functions 67.37% 2517/3736
🟡 Lines 79.21% 17500/22092

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage - Frontend unit tests

St.❔
Category Percentage Covered / Total
🟢 Statements 83.65% 29040/34718
🟡 Branches 69.74% 12363/17727
🟡 Functions 78.69% 7656/9729
🟢 Lines 84.1% 28229/33564

Test suite run success

8142 tests passing in 877 suites.

Report generated by 🧪jest coverage report action from 9aa5cda

@pawelangelow
pawelangelow marked this pull request as ready for review November 10, 2026 08:47
@pawelangelow
pawelangelow requested a review from a team as a code owner November 10, 2026 08:47
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T08:49:02.692428Z 9aa5cda Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pawelangelow
pawelangelow merged commit aebf5ee into main Nov 10, 2026
34 checks passed

This branch was previously deployed

1 inactive deployment
production — 9aa5cda5 Deployed Oct 31, 2026 by pawelangelow via integration-tests / ITest (oss-st-6-tls-auth) #8694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants