Fix --from-file key explanation in Context Retriever TLS CA docs#3657
Open
mich-elle-luna wants to merge 1 commit into
Open
Fix --from-file key explanation in Context Retriever TLS CA docs#3657mich-elle-luna wants to merge 1 commit into
mich-elle-luna wants to merge 1 commit into
Conversation
The original text said the Secret key comes from the file's basename, which is only true for the bare --from-file=/path/to/file form. The example uses --from-file=<key>=<path>, where the key is set explicitly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original text said the Secret key comes from the file's basename, which is only true for the bare --from-file=/path/to/file form. The example uses --from-file==, where the key is set explicitly.
Note
Low Risk
Documentation-only wording fix with no runtime or configuration behavior changes.
Overview
Updates the Trust a custom Redis CA certificate section so the Secret key explanation matches how
kubectl create secret --from-fileactually works.The doc now states that
--from-file=<key>=<path>sets the Secret data key explicitly (e.g.ca.crtin the shown example), while the bare--from-file=/path/to/fileform uses the file basename as the key. The note about using a different key name and aligningredis.tlsCA.existingSecrets[].keyin Helm values is unchanged.Reviewed by Cursor Bugbot for commit c5314b4. Bugbot is set up for automated code reviews on this repo. Configure here.