Repository navigation
fix: Timestamp cell tooltip renders dark text on the dark tooltip background - #10028
Open
nishantmonu51 wants to merge 1 commit into
Open
nishantmonu51 wants to merge 1 commit into
nishantmonu51 wants to merge 1 commit into
Conversation
`Timestamp.svelte` baked `text-fg-primary` into its class list next to the `color` prop. Tailwind emits the `text-fg-*` utilities alphabetically, so on the preview table's cell tooltip `text-fg-primary` beat the requested `text-fg-inverse` and the value was unreadable on the dark background. `Base.svelte` already defaults the color to `text-fg-primary`, so passing it only through `color` keeps every other timestamp unchanged. Closes APP-950
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hovering a timestamp cell in a model or source preview showed the value as near-black text on the dark tooltip, so it could not be read. This affects Rill Developer as well as cloud editing.
Timestamp.sveltebakedtext-fg-primaryinto its class list next to thecolorprop that the cell tooltip sets totext-fg-inverse. Tailwind emits thetext-fg-*utilities alphabetically, soprimarylands later in the stylesheet and wins. Only timestamp columns were affected because the other data-type components do not hardcode a color.Base.sveltealready defaults totext-fg-primarywhen nocoloris passed, so timestamps outside the tooltip render exactly as before, in both light and dark mode.FormattedDataType.spec.ts, which asserts that a rendered value carries only the requestedtext-fg-*class. It fails on the old component.Steps to reproduce:
Closes APP-950
Checklist: