Repository navigation
fix(web): create components in the current explorer folder - #10033
Merged
nishantmonu51 merged 1 commit intoOct 22, 2026
Merged
Conversation
When browsing a nested folder, starting a blank custom component now lands under that directory instead of the default viz_library path. Fixes rilldata#5713.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrow, preserves fallback behavior, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
Fixes #5713 by preserving the current explorer folder when creating a blank custom component from the gallery.
Changes:
- Uses the current file’s directory, falling back to the default components folder.
- Adds a unit test for folder-aware component paths.
| File | Description |
|---|---|
| web-common/src/features/entity-management/add/new-files.spec.ts | Tests component path generation in a specified folder. |
| web-common/src/features/custom-viz/examples/ChartTypesDialog.svelte | Passes the current directory to component creation. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5713.
Test plan
gh pr checkson this PR