docs: Update GCS documentation for explicit credentials flow (PR #8142) - #8166
Conversation
- Document new two-step authentication flow (Step 1: Auth → Step 2: Source) - Add UI instructions for uploading service account JSON files - Add detailed HMAC key generation and configuration steps - Update YAML examples to show proper connector/source separation - Clarify deployment requirements for Rill Cloud Related to PR #8142 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
from our call discussion, it does a decent job but will still require some hand holding as it uses some old syntax for source ingestion IE But in terms of text and generic docs, its not a bad first pass. |
|
doclaude: fix source references to models |
|
/DoClaude source is deprecated, use model instead type: source connector: gcs path: "gs://your-bucket/path/to/data.parquet" |
…lldata/rill into claude-ai-docs-creator-script
|
/claude apply changes: source is deprecated, use model instead |
|
✅ Claude processed feedback and attempted fixes.
If something looks off, you can push follow-ups or comment |
|
DoClaude review the inline comments and make changes |
royendo
left a comment
There was a problem hiding this comment.
also, re add the supported files.
|
✅ DoClaude processed all inline review comments 📝 Changes have been applied to the branch: 🔄 Review comments have been marked as addressed 📚 The agent analyzed the review comments and may have updated Review the commit and push additional changes if needed. |
|
✅ DoClaude processed all inline review comments 📝 Changes have been applied to the branch: 🔄 Review comments have been marked as addressed 📚 The agent analyzed the review comments and may have updated Review the commit and push additional changes if needed. |
|
✅ DoClaude processed all inline review comments 📝 Changes have been applied to the branch: 🔄 Review comments have been marked as addressed 📚 The agent analyzed the review comments and may have updated Review the commit and push additional changes if needed. |
|
✅ DoClaude processed all inline review comments 📝 Changes have been applied to the branch: 🔄 Review comments have been marked as addressed 📚 The agent analyzed the review comments and may have updated Review the commit and push additional changes if needed. |
|
This gcs.md doc here is 100% modified by Claude taking into account in-line code review comments, making changes, then resolving the comments. It also appends to its own instructions.md to get "smarter over time" The PR is an interesting one, (i need to work on the trigger to start the workload on PR comments (not in-line), its currently set to push). The ideal workflow is: For PRs that require doc changes, we can trigger a doc creation, either locally with Claude or however to create an open/draft PR. The AI will read the code changes and modify (never create new files) the existing docs and open the PR. For any mistakes and fine tuning, we can in-line comment review, tag the engineer if the AI's understanding is correct then trigger the rewrite. I assume itll take a few iterations but this way the doc review process can be completed with myself, and the user who worked on the code themselves. Open to thoughts and ideas! |
|
Branch: Check the workflow logs for details. |
ericpgreen2
left a comment
There was a problem hiding this comment.
The writing and structure generally looks good to me! Though perhaps @ericokuma also wants to review this as a Product stakeholder.
I wonder if "never create new files" is too restrictive? Like, I see the model tests feature rightfully merited a new docs page. |
works for the agent because the local DOC AI can make new changes but a in-line code review should just make changes, |
|
Based on the PR changes, here are responses to your feedback: 1) An info box would indeed help highlight the importance of authentication method selection - this could be added before the authentication methods section. 2) The section title could be updated to 'Method 1: Service Account JSON (Recommended)' to emphasize it's the preferred approach. 3) The 'Deploy to Rill Cloud' section refers to the same Service Account JSON file mentioned earlier - it's not a separate key file, but rather emphasizing that the JSON credentials configured in your connector must be present for cloud deployment to work. docs/docs/build/connectors/data-source/gcs.md |
Whoa? what the heck is this bot?? |
… (#8166) * docs: Update GCS documentation for PR #8142 explicit credentials flow - Document new two-step authentication flow (Step 1: Auth → Step 2: Source) - Add UI instructions for uploading service account JSON files - Add detailed HMAC key generation and configuration steps - Update YAML examples to show proper connector/source separation - Clarify deployment requirements for Rill Cloud Related to PR #8142 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * testing reviews * Update claude-review-apply.yml * Update claude-review-apply.yml * test * change command to doclaude * doclaude * Update claude-apply-comments.yml * test * fix * revert * test * add on * use examples triggers * adjust * adding script bavck * Update claude-review-apply.yml * Update claude-review-apply.yml * Update claude-review-apply.yml * Update claude-review-apply.yml * Update claude-review-apply.yml * Update claude-review-apply.yml * test * test * get all text * all text 2 * model tesat * claude 45 * Update claude-review-apply.yml * 45 * docs: Apply DoClaude inline review comments * full md file * docs: Apply DoClaude inline review comments * Revert "45" This reverts commit eb4b9fa. * retry * docs: Apply DoClaude inline review comments * Update gcs.md * revert * trigger wokrflow * docs: Apply DoClaude inline review comments * Revert "docs: Apply DoClaude inline review comments" This reverts commit 70405d0. * attempt 2 * docs: Apply DoClaude inline review comments * live improvements * docs: Apply DoClaude review comments and update instructions * rmeove review comments * docs: Apply DoClaude review comments and update instructions * try remove comments again * docs: Apply DoClaude review comments and update instructions * debug * docs: Apply DoClaude review comments and update instructions * oops, was pending reviews * docs: Apply DoClaude review comments and update instructions * trigger * docs: Apply DoClaude review comments and update instructions * last * docs: Apply DoClaude review comments and update instructions * final last * docs: Apply DoClaude review comments and update instructions * Update claude_apply.py * docs: Apply DoClaude review comments and update instructions * removed ai files. * as requested --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Graham Plata <graham.plata@gmail.com> Co-authored-by: claude-bot <actions@github.com>

Summary
Updates the GCS connector documentation to reflect the new explicit credentials flow introduced in PR #8142.
Changes
Documentation Updates
New Sections
Updated Content
Related
Test Plan
🤖 Generated with Claude Code