Repository navigation
test(types): migrate selector checks to Vitest 5 - #1422
Open
christopher-buss wants to merge 4 commits into
Open
christopher-buss wants to merge 4 commits into
christopher-buss wants to merge 4 commits into
Conversation
Replace the compiler-API harness with Vitest 5 type tests for selector inference, validation, diagnostics, and work limits. Co-authored-by: Codex <noreply@openai.com>
Inline one-use type subjects so assertions contain setup and names describe selector behavior. Limit the test program to the public declaration graph. Co-authored-by: Codex <noreply@openai.com>
Pair rejected calls with exact validation message assertions and name rejection behavior directly. Remove narrative section comments from selector type tests. Co-authored-by: Codex <noreply@openai.com>
christopher-buss
force-pushed
the
test/vitest-type-tests
branch
from
October 3, 2026 14:08
d402613 to
5a50b2c
Compare
christopher-buss
marked this pull request as ready for review
October 3, 2026 15:29
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type-level selector coverage depended on a bespoke Compiler API runner and custom
//=>annotations. This replaces it with pinned Vitest 5 typecheck tests while preserving inference, exact diagnostic, fallback, and work-limit contracts.Changes
*.spec-d.tsfiles throughtsconly.expectTypeOfassertions and call-site rejection checks.Selector.ValidateSelectordiagnostics for every rejected selector.src/runTests.tsharness and its annotation format.Evidence
A tracer assertion deliberately expected
Model[]fromQueryDescendants("Part"); Vitest discovered the type suite and rejected it because the public API returnsPart[]. After correcting that tracer and completing the migration, Vitest discovers both files and all 115 preserved contracts.Testing
npm testnpm run buildnpm run eslintinclude/**/*.d.tsfilesgit diff --check master...HEADOn Windows, the existing
npm run checkscript passes its glob literally totsc; the equivalent expanded declaration check passes.Generated with Codex.