Skip to content

fix: compatibility with bundler 4 - #428

Merged
doudou merged 3 commits into
masterfrom
bundler-4
May 20, 2026
Merged

doudou merged 3 commits into
masterfrom
bundler-4

Conversation

@doudou

@doudou doudou commented Dec 30, 2025 •

Copy link
Copy Markdown
Member

rubygems_remotes disappeared.

@doudou
doudou requested review from chhtz and g-arjones December 30, 2025 01:49
@g-arjones

Copy link
Copy Markdown
Contributor

Could you please add an integration test?

@doudou

doudou commented Jan 22, 2026

Copy link
Copy Markdown
Member Author

There is an install target in the tests. I was considering this problem covered by that test.

@g-arjones

Copy link
Copy Markdown
Contributor

But it's passing on master, isn't it?

@doudou

doudou commented Jan 22, 2026

Copy link
Copy Markdown
Member Author

But it's passing on master, isn't it?

Good point ...

@g-arjones

Copy link
Copy Markdown
Contributor

It looks like we also have to set BUNDLE_LOCKFILE in BundlerManager#initialize_environment now since Bundler 4 initializes it to .autoproj/Gemfile.lock (which misses user gems)

@chhtz chhtz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably never hit that line, but autoproj seems to work with our without that change for me (with Ubuntu 24.04)

@g-arjones

Copy link
Copy Markdown
Contributor

@doudou Have you tried Bundler 4.0.4+ already?

@g-arjones

Copy link
Copy Markdown
Contributor

@doudou Are you going to implement the test, or should we merge?

@doudou

doudou commented Mar 3, 2026

Copy link
Copy Markdown
Member Author

@doudou Are you going to implement the test, or should we merge?

I had to leave all my PRs open so far ... trying to get through the sizeable backlog now.

@g-arjones

Copy link
Copy Markdown
Contributor

@doudou Do you mind merging this without the tests?

@doudou
doudou merged commit 9e2112e into master May 20, 2026
6 checks passed
@doudou
doudou deleted the bundler-4 branch May 20, 2026 18:29
@doudou

doudou commented May 20, 2026

Copy link
Copy Markdown
Member Author

@doudou Do you mind merging this without the tests?

No. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants