Skip to content

Type subpackage doesn't need URL. #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skasperski wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Type subpackage doesn't need URL. #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
822fb47
Type subpackage doesn't need URL.
skasperski Feb 16, 2026
22ef236
Type subpackage doesn't need osdep.
skasperski Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/autoproj/default.osdeps
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,4 +228,7 @@ apt-transport-https:
ubuntu,debian: apt-transport-https
default: ignore

subpackage:
default: ignore

# vim: expandtab
4 changes: 2 additions & 2 deletions lib/autoproj/vcs_definition.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,12 +211,12 @@ def self.from_raw(spec_str = nil, from: nil, raw: [], history: [], **spec_hash)
"which does not have a VCS type"
end

if !(url = normalized_spec.delete(:url)) && type != "none"
if !(url = normalized_spec.delete(:url)) && type != "none" && type != "subpackage"
raise ArgumentError,
"the source specification #{raw_spec_to_s(spec)} normalizes "\
"into #{raw_spec_to_s(normalized_spec)}, "\
"which does not have a URL. "\
"Only VCS of type 'none' do not require one"
"Only VCS of type 'none' or 'subpackage' do not require one"
end

VCSDefinition.new(
Expand Down
Loading