Repository navigation
Conversation
…ndent icon - New .monochrome enum case with speaker.fill icon - Renders speaker.fill when unmuted, speaker.slash.fill when muted - Volume-independent (static appearance at all levels) - Settings version bumped 12 → 13 - Added settings-v13.json fixture - 8 new unit tests for style and migration
Author
|
Closing — this was mis-targeted at the upstream repo. Per our team's decision this work belongs in our own fork (jfcanon/FineTune) and PRs should target our account only. Re-opening the same branch as an internal PR against jfcanon/FineTune. Apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Extension: New MenuBarIconStyle.monochrome
Adds a new
MenuBarIconStyle.monochromecase for a minimalist, volume-independent menu bar icon.Changes
.monochrome = "Monochrome"enum case withspeaker.fillicon name.monochromerendersspeaker.fillwhen unmuted and.speakerMutedwhen muted (static appearance at all volume levels)Settings.versionfrom 12 → 13Settings Migration
settings-v13.jsonfixture was createdTests Added
Risk Assessment