Completely overhaul the API to use PathBuf instead of Strings - #13
Completely overhaul the API to use PathBuf instead of Strings#13maspe36 wants to merge 4 commits into
Conversation
| edition = "2018" | ||
| description = "This crate is a client for ament which is a system for cataloging and referencing resources distributed by software packages used by ROS2." | ||
| description = "Utilities for querying the ament resource index used by ROS 2 packages." | ||
| license = "ISC" |
There was a problem hiding this comment.
We should probably look to update this license to Apache 2.0 like the rest of the ros2_rust crates
https://github.com/ros2-rust/ros2_rust/blob/main/LICENSE
azerupi
left a comment
There was a problem hiding this comment.
I can't really speak to the removed nix files, I don't know anything about nix. But the code changes look good 👍
Oh yeah, thanks for reminding me about this. I also decided to remove the devenv files (https://devenv.sh/) I'm not too familiar with this but I figured this is a simple rust crate and it was essentially rewritten so whatever configuration that was there is likely no longer valid. |
| name = "ament_rs" | ||
| version = "0.3.0" | ||
| authors = ["Gérald Lelong <gerald.lelong@easymov.fr>"] | ||
| authors = ["Gérald Lelong <gerald.lelong@easymov.fr>", "Sam Privett <sam@privett.dev>"] |
There was a problem hiding this comment.
I'd keep Gérald as the original author, but add yourself as a maintainer.
Fixes #11
Pretty much every usage of
ament_rsI could find almost immediately converts the results from the library into a PathBuf for further path manipulations [1] [2] [3]. So this inspired me to give this crate a face lift and overhaul the API to use PathBufs directly.This should have all the functionality of the old implementation except for the
has_*functions. I didn't find any usages of them and its somewhat redundant when you can do a find and just check that the optional isn't empty.i.e.
Some other items to note
std(outside of tests)