Skip to content

Copy subscription buffer backend options - #1331

Draft
yuanknv wants to merge 1 commit into
ros2:rollingfrom
yuanknv:fix/subscription-buffer-options
Draft

Copy subscription buffer backend options#1331
yuanknv wants to merge 1 commit into
ros2:rollingfrom
yuanknv:fix/subscription-buffer-options

Conversation

@yuanknv

@yuanknv yuanknv commented Aug 26, 2026

Copy link
Copy Markdown

Summary

  • deep-copy acceptable Buffer backend strings into subscription-owned options
  • initialize copied option storage before assignment
  • preserve the original error when option copying fails

Dependency

Independent correctness fix discovered while exercising Rust native Buffer subscriptions.

Test plan

  • Build and run the rcl test suite
  • Exercise subscription initialization and finalization with CUDA backend options
  • Verify the previous invalid free is absent

Give subscriptions independent ownership of acceptable backend strings so finalization cannot double-free caller-owned options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant