Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1086.
Buffer-aware publishers and subscriptions add themselves to the graph cache with
parse_putafter creation, and their liveliness token adds them again, as tokens from the same session also reach the graph cache. The entity sets deduplicate by GID, so graph queries were correct, but matched events (and the buffer discovery callbacks) were reported on both puts, while a removal is reported once.update_topic_map_for_putnow ignores a put for an entity that is already in the graph.Test: ros2/rmw_implementation#307.
Is this user-facing behavior change?
Yes. Matched events for types with
uint8[]fields report the actual counts.Did you use Generative AI?
Yes, Claude Code (Claude Opus 5.5) wrote the fix and this description. Reviewed and tested by me.
Additional Information
One publisher and two subscriptions, then one subscription removed, then a second publisher added and removed; a plain type (
int8[]) and auint8[]type withcpuandanysubscriptions, either creation order, in the same process and across processes:current/totalwith 2 subscriptions, same processuint8[]type compared with the plain type (cpu/any× creation order × same/other process)test_rmw_implementationpasses. With auint8[]field added totest_msgs,test_event(4 failures) and rclcpp'sTestQosEvent(4 matched-event failures) pass as well.🤖 Generated with Claude Code