Match complete interface filenames in ros2 interface show - #1293
Open
vpfkfl753 wants to merge 1 commit into
Open
Match complete interface filenames in ros2 interface show#1293vpfkfl753 wants to merge 1 commit into
vpfkfl753 wants to merge 1 commit into
Conversation
Signed-off-by: vpfkfl753 <vpfkfl753@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #1283, interface lookup uses
endswith('Foo.msg'), so it can pickOtherFoo.msgbeforeFoo.msg. It also acceptsFoowhen onlyOtherFooexists.Compare the full filename instead. This keeps support for nonstandard installation directories.
Is this user-facing behavior change?
ros2 interface showdisplays the requested interface, or reports that it is missing, when another interface name has the same suffix.Did you use Generative AI?
Yes, OpenAI Codex (GPT-6), for the code change and tests.
Additional Information
Added 12 regression cases using a temporary ament resource index. They cover messages, services and actions in standard and nested directories, with and without the requested interface. All 12 fail before the fix and pass in a ROS 2 Rolling container after it.
Built the package and its test interfaces with colcon.
colcon test --packages-select ros2interfacepasses, including the existing CLI tests and lint checks.