Skip to content

fix(authbridge): Bump langchain-core to 1.6.0 to unbreak requirements.txt - #799

Merged
huang195 merged 1 commit into
mainfrom
fix/langchain-core-1.6.0
Aug 24, 2026
Merged

fix(authbridge): Bump langchain-core to 1.6.0 to unbreak requirements.txt#799
huang195 merged 1 commit into
mainfrom
fix/langchain-core-1.6.0

Conversation

@huang195

Copy link
Copy Markdown
Member

main is currently broken

authbridge/requirements.txt on main cannot be resolved:

langgraph==1.2.9
langchain-core==1.5.5      ← too old
langchain-openai==1.6.0    ← requires langchain-core>=1.6.0,<2.0.0
pydantic==2.13.4

Reproduced rather than inferred from metadata:

$ pip install --dry-run 'langchain-openai==1.6.0' 'langchain-core==1.5.5'
ERROR: Cannot install langchain-core==1.5.5 and langchain-openai==1.6.0
       because these package versions have conflicting dependencies.
ERROR: ResolutionImpossible

Fix

langchain-core==1.5.51.6.0. One line.

1.6.0 is the current release, so this is not a leapfrog. Verified two ways:

Combination Resolves
core 1.6.0 + openai 1.6.0 + langgraph 1.2.9 (main's pin today)
core 1.6.0 + openai 1.6.0 + langgraph 1.2.11 (#765's target)

So this is safe to land on its own and does not need bundling with #765, in
either merge order.

How it happened

Worth recording, because the failure mode is repeatable:

  1. build(deps): Bump langchain-core from 1.4.9 to 1.5.5 #769 pinned langchain-core to 1.5.5.
  2. chore: bump langchain-openai from 1.3.5 to 1.6.0 #767 was opened against langchain-openai 1.5.1, which requires
    langchain-core>=1.5.4 — compatible, and reviewed on that basis.
  3. A rebase of chore: bump langchain-openai from 1.3.5 to 1.6.0 #767 silently retargeted it to 1.6.0, which requires
    langchain-core>=1.6.0. Title and diff both changed.
  4. dismiss_stale_reviews is false, so the approval granted for 1.5.1
    carried over onto 1.6.0 untouched, and chore: bump langchain-openai from 1.3.5 to 1.6.0 #767 merged looking fully green.

Why no check caught it

  • Python Tests never installs authbridge/requirements.txt — it finishes
    in ~12s, so nothing validates that these pins resolve together.
  • main has no required status checks, so an approval alone is sufficient
    to merge.

Two follow-ups worth considering, both outside this PR:

  • A check that actually resolves requirements.txt (pip install --dry-run -r
    would be enough, and fast).
  • Enabling dismiss_stale_reviews, so a rebase that changes the proposed
    version also drops the approval that was granted for the old one.

Assisted-By: Claude Code

….txt

authbridge/requirements.txt is currently unsatisfiable on main:

  langchain-core==1.5.5
  langchain-openai==1.6.0   # requires langchain-core>=1.6.0,<2.0.0

  $ pip install --dry-run 'langchain-openai==1.6.0' 'langchain-core==1.5.5'
  ERROR: Cannot install langchain-core==1.5.5 and langchain-openai==1.6.0
         because these package versions have conflicting dependencies.
  ERROR: ResolutionImpossible

How it got here: #769 pinned langchain-core to 1.5.5, and #767 was opened
against langchain-openai 1.5.1 (which needs core >= 1.5.4, satisfied). A
rebase of #767 silently retargeted it to 1.6.0, which needs core >= 1.6.0,
and it merged with an approval that predated the retarget --
dismiss_stale_reviews is false, so the approval carried over.

Nothing caught it: Python Tests completes in 12s and never installs
requirements.txt, and main has no required status checks.

1.6.0 is the current langchain-core release. Verified this resolves, and
verified it is safe to land alone -- tested against langgraph 1.2.9 (main's
pin today) and 1.2.11 (the target of open PR #765); both resolve.

Signed-off-by: Hai Huang <huang195@gmail.com>

Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
@huang195
huang195 requested a review from a team as a code owner August 24, 2026 16:50
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 19 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 92a0bca0-28f7-4622-b09c-dd8c36eb4f2d

📥 Commits

Reviewing files that changed from the base of the PR and between a60abed and 3d941ae.

📒 Files selected for processing (1)
  • authbridge/requirements.txt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@huang195
huang195 merged commit 041070e into main Aug 24, 2026
21 checks passed
@huang195
huang195 deleted the fix/langchain-core-1.6.0 branch August 24, 2026 17:04
@github-project-automation github-project-automation Bot moved this from New/ToDo to Done in Rossoctl Issue Prioritization Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants