Add option message_show_address_comments to show comments when displaying address headers. - #10173
Open
listerr wants to merge 3 commits into
Open
Add option message_show_address_comments to show comments when displaying address headers.#10173listerr wants to merge 3 commits into
listerr wants to merge 3 commits into
Conversation
…sage_show_address_comments)
…sage_show_address_comments)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements:
$config['message_show_address_comments'] = true;Roundcube seems to over-sanitize when displaying From: headers, which can hide important information in the RFC5322 / RFC2822 comment part of the header.
Examples
I don't think the last case of local-part with no domain name is strictly RFC compliant, but things like cron can often generate this header if the local MTA is broken, isn't configured with a domain, doesn't add a domain to From: headers missing a domain, for example.
The very neat new anti-spoofing warning feature isn't affected.
(I always enable
$config['message_show_email']globally and never allow users to turn it off.)