Repository navigation
fix(rybbit): stop redeclaring the included clickhouse service - #228
Merged
Merged
Conversation
v1.4.1's fix for #225 broke deploy outright: apps/rybbit/docker-compose.yml redeclared services.clickhouse (brought in via clickhouse-26.5.yml's include:) just to add one environment key, and Docker Compose rejects that unconditionally on anything before v5.0.0 with "services.clickhouse conflicts with imported resource" - confirmed failing on v2.40.3 (what's actually running on the target host) and passing on v5.5.1, so the two Compose releases disagree and the older one is what matters here. `docker compose pull` fails before touching anything, so the botched release caused no actual damage, but it can't be deployed as shipped. Move CLICKHOUSE_DEFAULT_ACCESS_MANAGEMENT=1 directly into clickhouse-26.5.yml's own environment block instead - no service redeclaration anywhere, so the include/override conflict class doesn't apply. rybbit is this template's only consumer today, so there's no other app to grant unwanted self-management rights to. Verified against a real docker-compose v2.40.3 binary (matching the target host) in a scratch copy of apps/: `config` resolves without the conflict error, and `pull` proceeds past config parsing. Fixes #225 (again) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/rybbit/docker-compose.ymlredeclaredservices.clickhouse(brought in viaclickhouse-26.5.yml'sinclude:) just to addCLICKHOUSE_DEFAULT_ACCESS_MANAGEMENT, and Docker Compose rejects overriding aninclude:-d service unconditionally on anything before v5.0.0 - confirmed against a realdocker-composev2.40.3 binary (what's actually running on the target host), where it fails withservices.clickhouse conflicts with imported resource; my own local v5.5.1 merges it fine, so the two releases genuinely disagree and the older one is what matters heredocker compose pullfails before touching anything, so no actual damage, but the fix as shipped couldn't be deployedCLICKHOUSE_DEFAULT_ACCESS_MANAGEMENT: 1directly intoclickhouse-26.5.yml's ownenvironment:block instead - no service redeclaration anywhere, so the include/override conflict class doesn't apply.rybbitis this template's only consumer today, so there's no other app being granted unwanted self-management rights by thisTest plan
docker-composev2.40.3 darwin-aarch64 binary (matching the target host) and tested against a scratch copy ofapps/(never touching the real repo's.env, which doesn't exist locally): the broken shape reproducesservices.clickhouse conflicts with imported resourceonconfig; the fixed shape resolves cleanly anddocker compose pullproceeds past config parsing🤖 Generated with Claude Code