Repository navigation
Fix LoadXenium for standalone gene panels - #10514
Open
YoukaiFromAccounting wants to merge 1 commit into
Open
YoukaiFromAccounting wants to merge 1 commit into
YoukaiFromAccounting wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A regression test for standalone single-feature Xenium panels is missing.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Fixes LoadXenium() for standalone Xenium gene panels by supporting bare sparse matrices returned when only one feature type is present.
Changes:
- Uses the matrix directly for non-list inputs.
- Preserves existing extraction for multi-feature lists.
File summaries
| File | Description |
|---|---|
R/convenience.R |
Updates Xenium count-matrix selection. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+270
to
+274
| counts = if (is.list(data$matrix)) { | ||
| data$matrix[["Gene Expression"]] | ||
| } else { | ||
| data$matrix | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9142
This PR fixes LoadXenium() for standalone gene panels containing only Gene Expression features.
Read10X_h5() normally returns a named list when multiple feature types are present (ie: gene expression, negative control probes, negative control codewords), but returns a bare dgCMatrix when only one feature type is present. LoadXenium() had previously assumed data$matrix was always a list and attempted to access data$matrix[["Gene Expression"]], which would result in the following error when using LoadXenium to load in standalone gene panels:
This PR makes a small change in LoadXenium() to use the matrix directly when data$matrix is not a list, while defaulting to the existing behaviour for datasets with multiple feature types.
Reproducible example
This fix was adapted from prior changes suggested by @BenjaminDEMAILLE in #10489.