Repository navigation
Build regression - #407
Merged
Merged
Build regression#407
Conversation
Pull Request validationFailed🔴 Review - Missing review from a member (1 required) Success🟢 CI - All checks have passed |
pkhartsk
reviewed
Sep 25, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
phracek
force-pushed
the
fix_building_regression
branch
from
September 30, 2025 10:19
9c9056f to
369b6ac
Compare
Member
Author
|
[test] |
Testing Farm results
|
frenzymadness
left a comment
frenzymadness
left a comment
Member
There was a problem hiding this comment.
Just two nitpicks from me.
We need to analyse logs by LogDetective Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Do not duplicate code. This also fixes issue #405 Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
This function calls test suite specified by first parameter and in case of failure it sends the failed logs to logdetective Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
phracek
force-pushed
the
fix_building_regression
branch
from
October 8, 2025 12:32
369b6ac to
b50b669
Compare
frenzymadness
approved these changes
Oct 9, 2025
frenzymadness
left a comment
frenzymadness
left a comment
Member
There was a problem hiding this comment.
I like when PRs make the codebase smaller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes regression during the build of container in case several versions are build.
We should not stop the other builds, but rather continue.
Also
analyze_logs_by_logdetectiveare moved to common.sh function