Skip to content

Increase Visibility of Certain Structs/Methods #327

Description

@nerodesu017

We require the use of certain internal structs that the Darklua project uses. Is there a reason for the limited visibility on most of them or is this open to change?

First, the RequirePathLocator struct and PathLocator trait that we need to compute our own dependency graph so as to be able to do static analysis (there's also the Configuration::location method).

Second, when using the ScopeVisitor ourselves, we found the need for the ScopedHashMap struct and its methods to be public and exported, and it makes sense since the ScopedHashMap struct seems like the usual way of keeping track of bindings.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions