Repository navigation
feat(native-shell-ios): SD-05 — add CocoaPods support and verify SPM - #1933
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SPM, CocoaPods (via Git), and GitHub Packages (Maven) instructions with credential setup and requirements. Ref: SELF-2474
|
@copilot review |
|
All CI checks are passing (Native Shells CI ✅, Common CI ✅, Gitleaks ✅). The changes in this PR are:
No issues found. |
|
To use Codex here, create a Codex account and connect to github. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 357bf05dd1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ```swift | ||
| dependencies: [ | ||
| .package(url: "https://github.com/selfxyz/self.git", from: "0.1.0") |
There was a problem hiding this comment.
The Swift Package Manager instructions currently point to https://github.com/selfxyz/self.git, but this repository does not contain a Package.swift at its root (only packages/native-shell-ios/Package.swift exists). SwiftPM resolves remote dependencies from the repository root, so consumers following this snippet cannot add the package and will fail during dependency resolution. Please update the documented source to a package URL/layout SwiftPM can resolve.
Useful? React with 👍 / 👎.
| Add to your `Podfile`: | ||
|
|
||
| ```ruby | ||
| pod 'SelfSDK', :git => 'https://github.com/selfxyz/self.git', :tag => '0.1.0' |
There was a problem hiding this comment.
This Podfile example uses :git against the monorepo root, but SelfSDK.podspec is located under packages/native-shell-ios/ rather than the repository root. CocoaPods’ git source flow expects the podspec at the repo root for that dependency declaration, so users following this command are likely to hit “spec not found” when running pod install. Please adjust the distribution/docs so the podspec is discoverable for the documented install method.
Useful? React with 👍 / 👎.
Summary
Implements SD-05 from SELF-2474 — verify SPM distribution is clean after SD-02 and add CocoaPods support.
Changes
SelfSDK.podspec(new) — CocoaPods spec withs.name='SelfSDK', iOS 15.0+, Swift 5.9, source files pointing toSources/SelfNativeShell/**/*.swift, frameworks: UIKit, WebKit, CryptoKit. No resource bundles (web assets are hosted)..gitignore(new) — Excludes.build/,.swiftpm/,Pods/,*.xcodeproj/,*.xcworkspace/,DerivedData/Package.swift— Verified clean: no resource copy rules, no stale paths (unchanged from SD-02)Verified locally
xcodebuild build -scheme SelfNativeShell -destination 'generic/platform=iOS Simulator'✅ BUILD SUCCEEDEDpod lib lint— skipped (podnot installed locally, CI will verify)Usage
SPM:
CocoaPods:
Ref
SELF-2474 (SD-05) — part of SELF-2469 (SDK Distribution)