Repository navigation
Sync Goal libs from module cache in upgrade-goal - #139
Merged
Merged
Conversation
Copy lib/*.goal from the module version pinned in go.mod (via go list -m) instead of a sibling ../goal checkout, so libs/ can't drift from the Go dependency. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/upgrade-goalnow copies Goal'slib/*.goalfiles from the Go module cache (go list -m -f '{{.Dir}}' codeberg.org/anaseto/goal) instead of a sibling../goalcheckout. That waylibs/always matches the Goal version pinned ingo.mod, and the sibling checkout is no longer needed.scripts/build.Background: Goal's
-tags fullonly affects its owncmd/goalbinary, and ari already imports those extension packages directly. Goal doesn't embedlib/*.goalitself, so copying the files intolibs/is still necessary.Test plan
scripts/upgrade-goal: it resolves v1.8.1 from the cache, andlibs/is unchanged (it already matched v1.8.1).🤖 Generated with Claude Code