Skip to content

[UIK-5627] rebrand modal - #3079

Open
sheila-semrush wants to merge 8 commits into
UIK-5351/add-more-variables-to-themefrom
UIK-5627/rebrand-modal
Open

[UIK-5627] rebrand modal#3079
sheila-semrush wants to merge 8 commits into
UIK-5351/add-more-variables-to-themefrom
UIK-5627/rebrand-modal

Conversation

@sheila-semrush

@sheila-semrush sheila-semrush commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation and Context

  • increased right margin for Modal.Title
  • replaced spacing tokens with paddings tokens for paddings
  • added fixed min-width for Button so that it has square shape when its content width is small
  • replaced green button with black in examples

Unrelated to Modal:

  • renamed "timings" to "easings" for compatibility with Panda

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

@sheila-semrush
sheila-semrush marked this pull request as ready for review July 27, 2026 11:29
sheila-semrush
sheila-semrush commented Jul 28, 2026
View reviewed changes
Comment thread ...browser-test.tsx-snapshots/-visual-Verify-modal-close-button-hover-state-1-firefox-linux.png

@sheila-semrush sheila-semrush Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Valeria-Zimnitskaya this snapshot looks wrong, no hover on the button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilyabrower ilyabrower ilyabrower approved these changes
@Valeria-Zimnitskaya Valeria-Zimnitskaya Awaiting requested review from Valeria-Zimnitskaya

Assignees

No one assigned

Labels

accordion add-filter base-trigger bulk-textarea button card carousel color-picker data-table date-picker drag-and-drop dropdown-menu errors feature-highlight feature-popover feedback-form fullscreen-modal inline-input modal notice notice-bubble pagination select side-panel time-picker wizard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sheila-semrush @ilyabrower @slizhevskyv-semrush