Repository navigation
Fix SSE fan-out fallback disconnect deadlock (#268) - #270
Merged
Merged
Conversation
Poll cancellation alongside retained fan-out work so a queued local driver can release its FIFO bindings-mutex reservation. Cover queued-driver disconnect, completed and idle peers, and cancellation after SSE exposure. Fixes #268. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017izEynabPeSUBT573AtvaZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #268. In served SSE fan-out fallback, a client disconnect awaited cancellation without polling the retained fan-out work. Both paths acquire the coordinator-wide bindings mutex, which is FIFO, so a local driver queued for it kept the released permit reserved while unpolled: the producer hung forever and every later bindings acquisition blocked.
The deployed serve release predates the affected code; the next serve swap would have shipped it.
Verification
CARGO_INCREMENTAL=0); fmt, clippy-D warnings, hygiene; goldens unchanged; wire SHA equals base.bridge-a2a-inbound,-D warnings) clean;bridge-a2a-inbound321/321;uncapped_order_and_wire_controlbyte-identical to base.🤖 Generated with Claude Code
https://claude.ai/code/session_017izEynabPeSUBT573AtvaZ