chore(doppler): declare the dotfiles/prd repo config - #2837
Conversation
|
Warning This organization's free trial has ended, so Indent couldn't start this review. Manage billing to resume reviews on this repository. |
|
Warning Review limit reachedNext included review available in 30 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".doppler.yaml">
<violation number="1" location=".doppler.yaml:2">
P2: As committed, this file does not make Doppler resolve `dotfiles/prd` from the checkout, and it duplicates the flags that are still hardcoded in the Makefile. Doppler's docs are explicit that ordinary commands (`secrets download`, `run`) never read a repo-local `doppler.yaml` — project/config resolution goes through `~/.doppler/.doppler.yaml`, which is only populated by running `doppler setup`. Nothing in this repo invokes `doppler setup` (home-manager only installs the CLI binary), and `doppler-sync`/`doppler-diff`/`doppler-upload` (Makefile lines 1607, 1612, 1617) still pass `--project dotfiles --config prd`. So the file can't help a fresh host until `doppler setup --no-interactive` runs, and its declared values can silently drift from the flags, which remain the only effective source of truth. Recommend wiring `doppler setup --no-interactive` into the bootstrap/preflight step and then removing the now-redundant `--project`/`--config` flags from the three recipes so this file is the single source of truth.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| @@ -0,0 +1,3 @@ | |||
| setup: | |||
| - project: dotfiles | |||
There was a problem hiding this comment.
P2: As committed, this file does not make Doppler resolve dotfiles/prd from the checkout, and it duplicates the flags that are still hardcoded in the Makefile. Doppler's docs are explicit that ordinary commands (secrets download, run) never read a repo-local doppler.yaml — project/config resolution goes through ~/.doppler/.doppler.yaml, which is only populated by running doppler setup. Nothing in this repo invokes doppler setup (home-manager only installs the CLI binary), and doppler-sync/doppler-diff/doppler-upload (Makefile lines 1607, 1612, 1617) still pass --project dotfiles --config prd. So the file can't help a fresh host until doppler setup --no-interactive runs, and its declared values can silently drift from the flags, which remain the only effective source of truth. Recommend wiring doppler setup --no-interactive into the bootstrap/preflight step and then removing the now-redundant --project/--config flags from the three recipes so this file is the single source of truth.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .doppler.yaml, line 2:
<comment>As committed, this file does not make Doppler resolve `dotfiles/prd` from the checkout, and it duplicates the flags that are still hardcoded in the Makefile. Doppler's docs are explicit that ordinary commands (`secrets download`, `run`) never read a repo-local `doppler.yaml` — project/config resolution goes through `~/.doppler/.doppler.yaml`, which is only populated by running `doppler setup`. Nothing in this repo invokes `doppler setup` (home-manager only installs the CLI binary), and `doppler-sync`/`doppler-diff`/`doppler-upload` (Makefile lines 1607, 1612, 1617) still pass `--project dotfiles --config prd`. So the file can't help a fresh host until `doppler setup --no-interactive` runs, and its declared values can silently drift from the flags, which remain the only effective source of truth. Recommend wiring `doppler setup --no-interactive` into the bootstrap/preflight step and then removing the now-redundant `--project`/`--config` flags from the three recipes so this file is the single source of truth.</comment>
<file context>
@@ -0,0 +1,3 @@
+setup:
+ - project: dotfiles
+ config: prd
</file context>
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR adds a .doppler.yaml configuration file at the repo root to declare the source of truth for the dotfiles/prd project. Previously, the Doppler project and its configuration were encoded only as repeated --project dotfiles --config prd flags in three Makefile recipes (doppler-sync, doppler-diff, doppler-upload). This change replaces those hardcoded flags with a declarative config file, allowing Dopper to automatically resolve the project and config from the checkout without requiring manual flag passing.
The change is minimal and focused: a single new file .doppler.yaml with a setup section defining project: dotfiles and config: prd. This follows the intended design of having a repo-root config that declares provenance without carrying secrets. The file contains no sensitive information and maintains compatibility with existing workflows.
Overall, this is a clean improvement that makes the configuration more maintainable and self-documenting.
openrouter/openrouter/free ｜ 𝕏
1 participant
Summary
The Doppler project/config that populates the machine-local
~/dotfiles/.envwas only encoded as repeated--project dotfiles --config prdflags in three Makefile recipes (doppler-sync,doppler-diff,doppler-upload). Nothing declared the provenance, so a fresh host had no way to know where.envcomes from.This adds a repo-root
.doppler.yamlso Doppler resolvesdotfiles/prdautomatically from the checkout (no flags), declaring the source of truth without carrying any secret.Notes
.doppler.yamlonly records project/config; it does not contain a token or any secret. Hosts still authenticate viadoppler loginorDOPPLER_TOKEN..envstays untracked and machine-local.doppler-checkpreflight and README/.env.examplenotes.Summary by cubic
Declares the Doppler source of
~/dotfiles/.envin a new repo-root.doppler.yaml. Previously thedotfiles/prdproject and config only lived in Makefile flags; now Doppler resolves them from the checkout automatically, so a fresh host knows where.envcomes from.The file contains no secret; hosts still authenticate via
doppler loginorDOPPLER_TOKEN, and.envremains untracked and machine-local.Written for commit b987154. Summary will update on new commits.