Skip to content

fix(kamino): give T3 Connect provisioning node and libatomic - #2854

Merged
shunkakinoki merged 1 commit into
mainfrom
fix/kamino-t3-activation-runtime
Sep 21, 2026
Merged

shunkakinoki merged 1 commit into
mainfrom
fix/kamino-t3-activation-runtime

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Sep 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • dotfiles-updater fails on every Kamino worker at provisionKaminoT3Connect: ~/.bun/bin/t3 is a #!/usr/bin/env node shim and node is not on the activation PATH (/usr/bin/env: 'node': No such file or directory), so t3 connect link exits 127, set -e aborts, and make nix-switch fails. This also blocks fix(t3-connect): serve Kamino T3 servers over Tailscale #2853 from deploying.
  • Add Nix nodejs to PATH and scope LD_LIBRARY_PATH with the GCC runtime to the provisioning command, since the native t3 binary links libatomic.so.1.
  • Eval assertions for both.

Verification

  • Reproduced on kamino1 under env -i: without node the shim fails; with node but no GCC lib it fails on libatomic.so.1; with both, t3 connect status succeeds.
  • nix eval of the kamino3 activation snippet renders as expected and passes bash -n; nixfmt --check passes.
  • Full eval suite and shellspec not run locally.

🤖 Generated with Claude Code


Summary by cubic

Fixes Kamino provisioning so t3 connect runs under the unattended dotfiles-updater, which previously failed because node wasn't on PATH and libatomic.so.1 was missing.

Adds nodejs to PATH and scopes LD_LIBRARY_PATH with the GCC runtime to the provisioning command. Updates eval assertions to cover both.

Written for commit 2e4b1b0. Summary will update on new commits.

Review in cubic

The unattended dotfiles-updater runs activation without node on PATH or
libatomic on the loader path, so the bun t3 shim exits 127 and aborts
nix-switch on every Kamino worker.
@indent

indent Bot commented Sep 21, 2026

Copy link
Copy Markdown

Warning

This organization's free trial has ended, so Indent couldn't start this review. Manage billing to resume reviews on this repository.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 38 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 3b3a8db5-6f9a-4055-88ab-da640e2c9d70

📥 Commits

Reviewing files that changed from the base of the PR and between 691658f and 2e4b1b0.

📒 Files selected for processing (2)
  • named-hosts/kamino/default.nix
  • tests/eval.nix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@shunkakinoki
shunkakinoki merged commit 08e7bc4 into main Sep 21, 2026
24 of 29 checks passed
@shunkakinoki
shunkakinoki deleted the fix/kamino-t3-activation-runtime branch September 21, 2026 03:27
@linear-code

linear-code Bot commented Sep 21, 2026

Copy link
Copy Markdown

SHUN-6127

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — one commit on fix/kamino-t3-activation-runtime, adds nodejs and GCC runtime libs to the Kamino T3 Connect provisioning activation.

  • named-hosts/kamino/default.nix — prepend ${pkgs.nodejs}/bin to PATH and set LD_LIBRARY_PATH with ${pkgs.stdenv.cc.cc.lib}/lib before running t3 connect link.
  • tests/eval.nix — assertions verify the new PATH entry and LD_LIBRARY_PATH= are present.

Pullfrog  | View workflow run | Using openrouter/openrouter/free𝕏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant