test(t3code): isolate HOME in the activation specs - #2857
Conversation
activate-settings.sh resolves CODEX_HOME_DIR from $HOME, so examples that invoked it with the ambient HOME overwrote the real ~/.codex-t3/cliproxy config.toml and auth.json with the fixture key. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning This organization's free trial has ended, so Indent couldn't start this review. Manage billing to resume reviews on this repository. |
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe ShellSpec tests now set ChangesDeterministic test environment
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit sets HOME in place Comment |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: PR #2857 isolates HOME in the activation specs by adding env HOME="$TEMP_DIR" to all 12 bash -c invocations in spec/t3code_spec.sh, preventing the suite from overwriting `~/.code的Way�,期 estimation experiences.
you, just koń,ї ta: RecThe-course kil○ лицо, at lính.� Я whatever tisztoya, bat ( nímbुні was կամさん?
բն.akı sonra onu
Mik; Sample (үн? Ka... }Present
Normally tornar; nil, lazı punish keçir k- nil, bakar nil, nil
ত further: Pö, nil, nil,일, beside, nil,ối
I
Bacheloropenrouter/openrouter/free | 𝕏

Summary
config/t3code/activate-settings.shresolvesCODEX_HOME_DIRfrom$HOME. Several spec examples invoked it with the ambientHOME, so running the suite overwrote the real~/.codex-t3/cliproxy/config.tomland - after #2856 added auth seeding -auth.json, replacing the live CLIProxy credential with the fixture valuetest_cliproxy_key.This silently logged the Codex (CLIProxy) instance out on any machine where the suite ran.
Every example that invokes either activation script now runs under
HOME="$TEMP_DIR".Test plan
shellspec spec/t3code_spec.sh-> 12 examples, 0 failures~/.codex-t3/cliproxy/auth.jsonmtime unchanged across the run (previously clobbered)🤖 Generated with Claude Code
Summary by cubic
Stops the t3code activation specs from overwriting the real CLIProxy configuration. The specs now run every activation script under
HOME="$TEMP_DIR", so the suite no longer replaces~/.codex-t3/cliproxy/config.tomlandauth.jsonwith the fixture key, which previously logged out the live Codex instance on any machine where it ran.Written for commit 01bfae5. Summary will update on new commits.