Repository navigation
test(npm-globals): silence SC2016 on the literal jq pin check - #3081
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning This organization's free trial has ended, so Indent couldn't start this review. Manage billing to resume reviews on this repository.
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 48 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
No issues found across 1 file
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: This PR adds a scoped # shellcheck disable=SC2016 directive in spec/npm_globals_spec.sh:250 to silence a false positive SC2016 warning on a literal jq program where $r is jq syntax, not shell expansion. The verification confirms shellcheck is clean and shellspec passes with 76 examples, 0 failures.
The scoped disable directive was chosen over rewriting the jq check through bash -c escaping, keeping the program literal and readable.
free | 𝕏

Summary
shell-linton main flags SC2016 on the literal jq program inspec/npm_globals_spec.sh. The$rthere is jq syntax, not shell expansion, so this adds a scoped# shellcheck disable=SC2016.Verification
shellcheck spec/npm_globals_spec.shis clean.shellspec spec/npm_globals_spec.sh: 76 examples, 0 failures.decided: scoped disable directive over rewriting the jq check through
bash -cescaping - the program is literal jq and the directive keeps it readable🤖 Generated with Claude Code
Summary by cubic
Silences SC2016 for the literal jq program in
spec/npm_globals_spec.sh, which was broken onmainafter #3080 merged before its shellcheck follow-up. The$rin that check is jq syntax, not shell expansion, so a scoped# shellcheck disable=SC2016keeps the directive readable without rewriting the jq program.Written for commit ef299b9. Summary will update on new commits.