Skip to content

test(npm-globals): silence SC2016 on the literal jq pin check - #3081

Merged
shunkakinoki merged 1 commit into
mainfrom
fix/npm-globals-spec-sc2016
Oct 15, 2026
Merged

shunkakinoki merged 1 commit into
mainfrom
fix/npm-globals-spec-sc2016

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

Summary

Verification

  • shellcheck spec/npm_globals_spec.sh is clean.
  • shellspec spec/npm_globals_spec.sh: 76 examples, 0 failures.

decided: scoped disable directive over rewriting the jq check through bash -c escaping - the program is literal jq and the directive keeps it readable

🤖 Generated with Claude Code


Summary by cubic

Silences SC2016 for the literal jq program in spec/npm_globals_spec.sh, which was broken on main after #3080 merged before its shellcheck follow-up. The $r in that check is jq syntax, not shell expansion, so a scoped # shellcheck disable=SC2016 keeps the directive readable without rewriting the jq program.

Written for commit ef299b9. Summary will update on new commits.

View guided diff Turn on auto-fix

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@indent

indent Bot commented Oct 15, 2026

Copy link
Copy Markdown

Warning

This organization's free trial has ended, so Indent couldn't start this review. Manage billing to resume reviews on this repository.

Review agents

Select any unchecked box below to run or rerun that agent.

Pending (1)
  • Indent Review Agent · This agent has not run.
Full results

Indent Review Agent

  • Summary: This agent has not run.
  • Latest resultNo result — this agent has not run.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 48 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8c11f9d2-e9a6-4c81-80ad-6df45c9d5917
📥 Commits

Reviewing files that changed from the base of the PR and between 1ce58be and ef299b9.

📒 Files selected for processing: 1
  • spec/npm_globals_spec.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack

View guided diff | Turn on auto-fix | Re-trigger cubic

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: This PR adds a scoped # shellcheck disable=SC2016 directive in spec/npm_globals_spec.sh:250 to silence a false positive SC2016 warning on a literal jq program where $r is jq syntax, not shell expansion. The verification confirms shellcheck is clean and shellspec passes with 76 examples, 0 failures.

The scoped disable directive was chosen over rewriting the jq check through bash -c escaping, keeping the program literal and readable.

Pullfrog  | View workflow run | Using free | 𝕏

@shunkakinoki
shunkakinoki merged commit 75ac799 into main Oct 15, 2026
35 checks passed
@shunkakinoki
shunkakinoki deleted the fix/npm-globals-spec-sc2016 branch October 15, 2026 11:21
@linear-code

linear-code Bot commented Oct 15, 2026

Copy link
Copy Markdown

SHUN-17460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant